From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23178 invoked by alias); 6 Oct 2013 19:59:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23167 invoked by uid 89); 6 Oct 2013 19:59:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 Oct 2013 19:59:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r96JxHfH019371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 6 Oct 2013 15:59:17 -0400 Received: from host2.jankratochvil.net (ovpn-116-31.ams2.redhat.com [10.36.116.31]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r96JxDFv023188 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 6 Oct 2013 15:59:16 -0400 Date: Sun, 06 Oct 2013 19:59:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: [+rfc] Re: [patch v6 00/21] record-btrace: reverse Message-ID: <20131006195913.GA2518@host2.jankratochvil.net> References: <1379676639-31802-1-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379676639-31802-1-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00171.txt.bz2 On Fri, 20 Sep 2013 13:30:18 +0200, Markus Metzger wrote: > This is a small update of v5 that fixes the test fail when using "finish" > in a tail call frame. The fix only changes "record-btrace: extend unwinder" > and resolves a resulting conflict in "record-btrace: add (reverse-)stepping > support". Besides some nitpicks there remains the larger request Re: [patch v4 23/24] record-btrace: add (reverse-)stepping support https://sourceware.org/ml/gdb-patches/2013-09/msg01004.html Message-ID: <20130930102533.GA29665@host2.jankratochvil.net> to always use to_resume + to_wait for any change of history position. This also means the "hacks" like +record_btrace_goto_end (void) + print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1); can be removed as normal GDB inferior stop will print the frame. Other comments are welcome if it is not a too strict requirement from me but I think we could face some forgotten resetting of future caches avoiding the normal resume+wait path this way. Or ... we would not face them but it would violate localized of cache resets in to_resume+to_wait code path. Thanks, Jan