From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19668 invoked by alias); 6 Oct 2013 19:52:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19659 invoked by uid 89); 6 Oct 2013 19:52:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 06 Oct 2013 19:52:03 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r96Jq1sr014493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 6 Oct 2013 15:52:01 -0400 Received: from host2.jankratochvil.net (ovpn-116-31.ams2.redhat.com [10.36.116.31]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r96JpwFu032488 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 6 Oct 2013 15:52:00 -0400 Date: Sun, 06 Oct 2013 19:52:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [patch v6 21/21] record-btrace: add (reverse-)stepping support Message-ID: <20131006195158.GF28020@host2.jankratochvil.net> References: <1379676639-31802-1-git-send-email-markus.t.metzger@intel.com> <1379676639-31802-22-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379676639-31802-22-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00170.txt.bz2 On Fri, 20 Sep 2013 13:30:39 +0200, Markus Metzger wrote: [...] > --- a/gdb/btrace.h > +++ b/gdb/btrace.h > @@ -153,6 +153,25 @@ struct btrace_call_history > struct btrace_call_iterator end; > }; > > +/* Branch trace thread flags. */ > +enum btrace_thread_flag > +{ > + /* The thread is to be stepped forwards. */ > + BTHR_STEP = (1 << 0), > + > + /* The thread is to be stepped backwards. */ > + BTHR_RSTEP = (1 << 1), > + > + /* The thread is to be continued forwards. */ > + BTHR_CONT = (1 << 2), > + > + /* The thread is to be continued backwards. */ > + BTHR_RCONT = (1 << 3), > + > + /* The thread is to be moved. */ > + BTHR_MOVE = (BTHR_STEP | BTHR_RSTEP | BTHR_CONT | BTHR_RCONT) > +}; The content should be indented by two spaces, not by four. > + > /* Branch trace information per thread. > > This represents the branch trace configuration as well as the entry point [...] > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 1098b60..50e7206 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -6192,8 +6192,8 @@ replay implementation. This method allows replaying and reverse > execution. > > @item btrace > -Hardware-supported instruction recording. This method does not allow > -replaying and reverse execution. > +Hardware-supported instruction recording. This method does not record > +data. It allows limited replay and reverse execution. As discussed in Message-ID: the documentation should mention the full history is usually not kept as the btrace buffer commonly overflows. Otherwise user may be curious why the btrace history is always relatively short. I would see it worth a comment even in (gdb) help record btrace Start branch trace recording. > This recording method may not be available on all processors. > @end table Thanks, Jan