From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24794 invoked by alias); 1 Oct 2013 10:07:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24770 invoked by uid 89); 1 Oct 2013 10:07:45 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 01 Oct 2013 10:07:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 422B9116651; Tue, 1 Oct 2013 06:08:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 16rWRKeBdE42; Tue, 1 Oct 2013 06:08:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1666111664A; Tue, 1 Oct 2013 06:08:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3559FE0486; Tue, 1 Oct 2013 12:07:42 +0200 (CEST) Date: Tue, 01 Oct 2013 10:07:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] Remove vlang_unknown Message-ID: <20131001100742.GC2840@adacore.com> References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-3-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379512482-31773-3-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00029.txt.bz2 > 2013-09-18 Yao Qi > > * varobj.c (varobj_format_string): Remove "unknown". > (languages): Remove the first element. > * varobj.h (enum varobj_languages): Remove vlang_c. Overall, looks good to me. > diff --git a/gdb/varobj.h b/gdb/varobj.h > index 05b2c94..d4abb99 100644 > --- a/gdb/varobj.h > +++ b/gdb/varobj.h > @@ -55,7 +55,7 @@ extern char *varobj_format_string[]; > /* Languages supported by this variable objects system. */ > enum varobj_languages > { > - vlang_unknown = 0, vlang_c, vlang_cplus, vlang_java, vlang_ada, vlang_end > + vlang_c = 0, vlang_cplus, vlang_java, vlang_ada, vlang_end I am not really sure why the first enum would need to be zero. If we cannot find an answer to that question, I propose you leave the "= 0" out of this patch. -- Joel