Re: Setting parity for remote serial

Yurij Grechishhev
2013-07-25T07:15:21Z

Spaces in ChangeLog are due to the mail client. I could send the attachement.

--- ../../../gdb_old/gdb-7.6/gdb/doc/ChangeLog 2013-07-10
21:55:24.921750052 +0400
+++ gdb/doc/ChangeLog 2013-07-25 14:50:14.960811746 +0400
@@ -1,3 +1,8 @@
+2013-07-16 Yurij Grechishhev <yurij.grechishhev@gmail.com>
+
+ * gdb.texinfo (Remote configuration): Document "set/show
+ remoteparity".
+
2013-04-12 Jan Kratochvil <jan.kratochvil@redhat.com>
Eli Zaretskii <eliz@gnu.org>

--- ../../../gdb_old/gdb-7.6/gdb/ChangeLog 2013-07-10
21:55:22.485750321 +0400
+++ gdb/ChangeLog 2013-07-25 14:24:03.806935947 +0400
@@ -1,3 +1,30 @@
+2013-07-16 Yurij Grechishhev <yurij.grechishhev@gmail.com>
+
+ * NEWS: Mention set/show remoteparity command.
+ * monitor.c (monitor_open): Add serial_setparity.
+ * remote.c (remote_open_1): Likewise.
+ * ser-base.c (ser_base_serparity): New function.
+ * ser-base.h: Add ser_base_setparity declaration.
+ * serail.c: Add serial_parity declaration and definitions of
+ parity_enums and parity.
+ (set_parity): New function.
+ (serial_setparity): New function.
+ (_initialize_serial): Add set/show remoteparity command description
+ * serial.h: Add GDBPARITY_NONE, GDBPARITY_ODD, GDBPARITY_EVEN
+ definitions. Add serial_setparity declaration.
+ (serial_ops): Add setparity entry.
+ * ser-mingw.c (ser_windows_raw): Remove state.fParity and
+ state.Parity definitions.
+ (ser_windows_setparity): New function.
+ (_initialize_ser_windows): ops->setparity setting.
+ * ser-pipe.c (_initialize_ser_pipe): Likewise.
+ * ser-tcp.c (_initialize_ser_tcp): Likewise.
+ * ser-unix.c: Add hardwire_setparity declaration.
+ (hardwire_setparity): New function.
+ (_initialize_ser_hardwire): ops->setparity setting.
+ * target.h: serial_parity declaration.
+ * top.c: serial_parity definition.
+
2013-04-26 Joel Brobecker <brobecker@adacore.com>

* NEWS: Change "since GDB 7.5" into "in GDB 7.6".

--- ../../../gdb_old/gdb-7.6/gdb/doc/gdb.texinfo 2013-07-10
21:55:25.257751657 +0400
+++ gdb/doc/gdb.texinfo 2013-07-25 14:18:36.581811831 +0400
@@ -18168,6 +18168,13 @@ default is not to record at all.
Show the current setting of the file name on which to record the
serial communications.

+@item set remoteparity @var{parity}
+Set the parity for the remote serial I/O. Supported values of
@var{parity} are:
+@code{even}, @code{none}, and @code{odd}. The default is @code{none}.
+
+@item show remoteparity
+Show the current parity of the serial port.
+
@item set remotetimeout @var{num}
@cindex timeout for serial communications
@cindex remote timeout

--- ../../../gdb_old/gdb-7.6/gdb/NEWS 2013-07-10 21:55:32.402748483 +0400
+++ gdb/NEWS 2013-07-25 14:26:00.463811247 +0400
@@ -3,6 +3,10 @@

*** Changes in GDB 7.6

+* GDB has two new commands: "set remoteparity odd|even|none" and
+ "show remoteparity". These allows to set or show parity for the
+ remote serial I/O.
+
* Target record has been renamed to record-full.
Record/replay is now enabled with the "record full" command.
This also affects settings that are associated with full record/replay

--
With best regards!
____________________________

Yurij Grechishhev
Bauman State Technical University,
Department of Computer Systems and Networks

2013/7/24 Eli Zaretskii <eliz@gnu.org>:
>> Date: Wed, 24 Jul 2013 18:29:11 +0400
>> From: Yurij Grechishhev <yurij.grechishhev@gmail.com>
>>
>> Updated patch for serial parity support:
>
> Thanks.
>
>> +++ gdb/doc/ChangeLog 2013-07-16 18:46:31.425614819 +0400
>> @@ -1,3 +1,6 @@
>> +2013-07-16 Yurij Grechishhev <yurij.grechishhev@gmail.com>
>> + * gdb.texinfo (Remote configuration): Document "set/show
>> + remoteparity".
>> 2013-04-12 Jan Kratochvil <jan.kratochvil@redhat.com>
>> Eli Zaretskii <eliz@gnu.org>
>
> You need to leave an empty line between your ChangeLog entry and the
> previous one. Also, each line in ChangeLog should begin with TAB
> character, not with spaces.
>
>> +@item set remoteparity @var{parity}
>> +Set the parity for the remote serial I/O. Supported values of @var{parity} are:
>> +@code{even}, @code{none}, and @code{odd}. The default is @code{none}.
>
> Two spaces between sentences, please.
>
> The documentation part is okay with these changes.
>
> What about NEWS?

--
With best regards!
____________________________

Yurij Grechishhev
Bauman State Technical University,
Department of Computer Systems and Networks