From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23523 invoked by alias); 24 Sep 2013 16:53:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23477 invoked by uid 89); 24 Sep 2013 16:53:10 -0000 Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 24 Sep 2013 16:53:10 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r8OGr2NO002528; Tue, 24 Sep 2013 18:53:02 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r8OGr2lb015683; Tue, 24 Sep 2013 18:53:02 +0200 (CEST) Date: Tue, 24 Sep 2013 16:53:00 -0000 Message-Id: <201309241653.r8OGr2lb015683@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: gdb-patches@sourceware.org In-reply-to: <1380040404-16932-1-git-send-email-brobecker@adacore.com> (message from Joel Brobecker on Tue, 24 Sep 2013 09:33:20 -0700) Subject: Re: [RFC-v2] amd64-windows: Fix funcall with by-pointer arguments References: <20130920232017.GU3132@adacore.com> <1380040404-16932-1-git-send-email-brobecker@adacore.com> X-SW-Source: 2013-09/txt/msg00871.txt.bz2 > From: Joel Brobecker > Date: Tue, 24 Sep 2013 09:33:20 -0700 > > Hello, > > > Once again, I'm short of time to finish what I had hoped to be able > > to complete. But I thought I'd send an update anyway. The first patch > > is an update to the patch I wrote in January, rebased for today's HEAD. > > This is what I have tested and intend to check in soon. > > > > Left to do on my end, is clean things up in amd64-tdep, because many > > hooks in the tdep structure can now be removed, and replaced by > > direct calls. But this is independent of your changes, so we can > > both work at the same time. > > I have now checked in the patch re-implementing function call on > amd64-windows. After this was done, I was able to revert all changes > that added hooks in the gdbarch_tdep and in the amd64 sysV code > to tweak it for amd64-windows, since the two implementations are > now completely distinct. > > All patches were tested on x86_64-linux and x86_64-windows. > And just in case, I tested them on x86-windows as well. Thanks a bunch Joel!