Hello again Pierre, > This all made me realize that merging our two patches creates > a bit of confusion about what is a pure rewrite, and what is an > attempt to fix what. > > So, here is what I will do: I will clean my patch up, retest, > also remove all amd64-windows-specific hooks as initially said, > and then send you an updated patch containing your changes, with > my fixes. If you could please: > 1. Re-test, making sure that I did not break anything back; > 2. Re-submit each piece for each problem that you're solving, > with description provided with each patch. > > This will make the review process easier for me. Once again, I'm short of time to finish what I had hoped to be able to complete. But I thought I'd send an update anyway. The first patch is an update to the patch I wrote in January, rebased for today's HEAD. This is what I have tested and intend to check in soon. Left to do on my end, is clean things up in amd64-tdep, because many hooks in the tdep structure can now be removed, and replaced by direct calls. But this is independent of your changes, so we can both work at the same time. The second patch are your changes, adjusted to fix the one bug I found, and also to better follow our coding style. From memory: - When breaking lines in function calls, place the opening '(' on the next line rather than breaking after it; - if COND then return X; else return 0; => Replaced by return (COND && X) It's not better, but shortens the code a little, which helps when inside a large switch/case block - No i18n required for debug traces You can now start submitting your changes on top of mine anytime, and I will try to review them promptly. Please try to break them up and explain the rationale behind them (what problem do they fix, for instance, and also, if there are already some tests in our testsuite that go from FAIL to PASS thanks to your patch). The hunks adding debug traces, for instance, could be sent separately. Thank you, -- Joel