From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30030 invoked by alias); 20 Sep 2013 18:14:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30020 invoked by uid 89); 20 Sep 2013 18:14:07 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2013 18:14:07 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8KIE3ID016723 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 Sep 2013 14:14:03 -0400 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8KIDx3s005544 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 20 Sep 2013 14:14:01 -0400 Date: Fri, 20 Sep 2013 18:14:00 -0000 From: Jan Kratochvil To: Andreas Arnez Cc: gdb-patches@sourceware.org, Andreas Krebbel Subject: Re: [PATCH] Skip VDSO when reading SO list Message-ID: <20130920181359.GA29967@host2.jankratochvil.net> References: <87d2p9oi4i.fsf@br87z6lw.de.ibm.com> <20130920131549.GA18629@host2.jankratochvil.net> <87siwzpgx4.fsf@br87z6lw.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87siwzpgx4.fsf@br87z6lw.de.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00779.txt.bz2 On Fri, 20 Sep 2013 19:00:07 +0200, Andreas Arnez wrote: > Jan Kratochvil writes: > > Here should be also '&& ignore_first'. > > Hm, this shouldn't be necessary, because 'first' is only set when > 'ignore_first' is set. Or did I miss something? I agree now, replied in another mail. > >> + { > >> + do_cleanups (old_chain); > >> + continue; > >> + } > > > > And move this block below so that the condition is evaluated only if > > target_read_string has really failed. > > > > The purpose is that no workarounds should complicate the code in the case the > > system components are already bug-free (after glibc gets fixed). > > That's a good point. Still, after thinking about this some more, I > prefer the order in the original patch, because it prevents a bogus > l_name from being detected in a second scan when the core dump is > debugged on a system with a different glibc version. Users may also > experience this after a glibc update. Thoughts? If you use non-matching glibc then it should complain. In such case there is a pointer to some real string so it is correct GDB tries to read it as a library. While the library load will fail it does not block trying to debug such a core file. A bit off-topic but for the non-matching libraries I should upstream the patch (plus some related patches therein) http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-buildid-locate.patch as then it does not try to load non-matching executable/libraries at all. Thanks, Jan