From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21768 invoked by alias); 19 Sep 2013 14:19:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21757 invoked by uid 89); 19 Sep 2013 14:19:34 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 19 Sep 2013 14:19:34 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F12D91160ED; Thu, 19 Sep 2013 10:19:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xkzdrFuohOGr; Thu, 19 Sep 2013 10:19:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C9A3511609D; Thu, 19 Sep 2013 10:19:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2B8CBE030E; Thu, 19 Sep 2013 07:19:31 -0700 (PDT) Date: Thu, 19 Sep 2013 14:19:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patchv4 3/5] new: solib-sunos.c objfile unification [test needed] Message-ID: <20130919141931.GR3132@adacore.com> References: <20130919135623.GC16978@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130919135623.GC16978@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00682.txt.bz2 > gdb/ > 2013-09-18 Jan Kratochvil > > * solib-sunos.c (allocate_rt_common_objfile): Replace it by an > allocate_objfile call. > (solib_add_common_symbols): Call free_objfile and allocate_objfile > instead. If this is really used on Solaris, I wouldn't mind testing it (though only with our internal testing, as something in the official testing badly crashes every single of our Solaris machine). But isn't this file only used in the case of (old) SunOS, that is pre-Solaris? Actually, a quick grep shows: ./config/vax/nbsdaout.mh: solib-sunos.o ./config/sparc/nbsdaout.mh: sparc-nat.o sparcnbsd-nat.o bsd-kvm.o solib-sunos.o ./config/m68k/nbsdaout.mh: solib-sunos.o ./config/m68k/obsd.mh: solib-sunos.o ./config/arm/nbsdaout.mh: solib-sunos.o ./config/i386/nbsdaout.mh: solib-sunos.o ./config/i386/obsdaout.mh: solib-sunos.o I must be missing something, or else did you build with --enable-targets=all? -- Joel