From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16294 invoked by alias); 17 Sep 2013 12:30:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16245 invoked by uid 89); 17 Sep 2013 12:30:45 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 17 Sep 2013 12:30:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AE09811648D; Tue, 17 Sep 2013 08:30:56 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iAwHl85+ijyl; Tue, 17 Sep 2013 08:30:56 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7C8CA11636A; Tue, 17 Sep 2013 08:30:56 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7D784E1290; Tue, 17 Sep 2013 05:30:42 -0700 (PDT) Date: Tue, 17 Sep 2013 12:30:00 -0000 From: Joel Brobecker To: Jiong Wang Cc: gdb-patches@sourceware.org Subject: Re: [RFC/TileGX 1/2] fix gdbserver build failure Message-ID: <20130917123042.GD3132@adacore.com> References: <50F9148F.3010602@tilera.com> <5237C847.3040908@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5237C847.3040908@tilera.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00493.txt.bz2 > TileGX gdbserver build failed on native board. > > "srv_tgtobj“ in gdbserver/configure.src not updated. > > > gdbserver/ChangeLog: > > * configure.srv (srv_tgtobj): Remove linux-osdata.o, add linux-tile-low.o. > > please review. I am trying to understand the circumstances that lead to the failure, and it's been made harder due to the lack of information. After some investigation, my guess is that you're getting some duplicate symbols because linux-osdata.o" is already in srv_tgtobj. Is that correct? If yes, this part of the patch is OK, obvious even (once explained!). I don't understand, however, what difference adding linux-tile-low.o makes in terms of build failure. Again, I have been trying to figure out what lead to the failure, and searched our recent past, but could not find anything. I know the change makes complete sense, but if not logically tied to the build failure you are mentioning, I think we should, if nothing else, document that fact for future archival, and also commit this part of the change separately. > diff --git a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv > index 6eb5a8a..f65dd10 100644 > --- a/gdb/gdbserver/configure.srv > +++ b/gdb/gdbserver/configure.srv > @@ -340,7 +340,7 @@ case "${target}" in > ;; > tilegx-*-linux*) srv_regobj=reg-tilegx.o > srv_regobj="${srv_regobj} reg-tilegx32.o" > - srv_tgtobj="$srv_linux_obj linux-osdata.o" > + srv_tgtobj="$srv_linux_obj linux-tile-low.o" > srv_linux_regsets=yes > srv_linux_thread_db=yes > ;; -- Joel