From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2204 invoked by alias); 26 Aug 2013 15:30:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2192 invoked by uid 89); 26 Aug 2013 15:30:23 -0000 Received: from e06smtp18.uk.ibm.com (HELO e06smtp18.uk.ibm.com) (195.75.94.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 26 Aug 2013 15:30:23 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: e06smtp18.uk.ibm.com Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 26 Aug 2013 16:23:21 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp18.uk.ibm.com (192.168.101.148) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 26 Aug 2013 16:23:18 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 299A717D8059 for ; Mon, 26 Aug 2013 16:32:13 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7QFU3fp33358078 for ; Mon, 26 Aug 2013 15:30:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7QFUDTX022461 for ; Mon, 26 Aug 2013 09:30:14 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id r7QFUBt8022431; Mon, 26 Aug 2013 09:30:11 -0600 Message-Id: <201308261530.r7QFUBt8022431@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 26 Aug 2013 17:30:11 +0200 Subject: Re: [PATCH 2/5] powerpc64-aix processing xlC generated line table To: raunaq12@in.ibm.com (Raunaq 12) Date: Mon, 26 Aug 2013 15:30:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com, gdb-patches@sourceware.org, palves@redhat.com (Pedro Alves), tromey@redhat.com In-Reply-To: from "Raunaq 12" at Aug 12, 2013 01:19:04 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13082615-6892-0000-0000-0000061BBAA1 X-SW-Source: 2013-08/txt/msg00745.txt.bz2 Raunaq Bathija wrote: > "Ulrich Weigand" wrote on 08/09/2013 03:31:21 AM: > > Well, the test suite is supposed to handle different compilers, > > but since only very few people test with anything but GCC, > > support for other compilers tends to bit-rot. As a suggestion > > to help with future maintainability of GDB on AIX, it would be > > nice if you could go through the test suite at some point and > > clean those problems up ... > > Agreed, that would greatly help with future maintainablity of GDB on AIX. > Will plan to take that task up once I am done fixing some other > issues faced by GDB on AIX like stabstring support for XLC++ compiled > binaries. Thanks! > Thanks for taking time to write this Ulrich. This does solve the problem > but one > extra line had to be added to update the number of items in the line table > as > seen below, > > - newLineTb->nitems = oldLineTb->nitems - function_count; > + newLineTb->nitems = oldLineTb->nitems - function_count + extra_lines; > > Added this line and ran the related testcases. Results same as before. > > Can we go ahead and check this in? Looks good, and thanks for testing! I've checked this in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com