From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18189 invoked by alias); 26 Aug 2013 05:31:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18173 invoked by uid 89); 26 Aug 2013 05:31:16 -0000 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 26 Aug 2013 05:31:16 +0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id CBB5A33EB9C; Mon, 26 Aug 2013 05:31:13 +0000 (UTC) From: Mike Frysinger To: lgustavo@codesourcery.com Subject: Re: [PATCH, gdbserver] Further cleanup of FDPIC/DSBT divergences Date: Mon, 26 Aug 2013 05:31:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.10.6; KDE/4.6.5; x86_64; ; ) Cc: Pedro Alves , Yao Qi , "'gdb-patches@sourceware.org'" References: <51C34F14.8070803@codesourcery.com> <520505D9.8080103@redhat.com> <520524D8.40408@codesourcery.com> In-Reply-To: <520524D8.40408@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4040894.eUx3JmxqnP"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201308260131.20126.vapier@gentoo.org> X-SW-Source: 2013-08/txt/msg00730.txt.bz2 --nextPart4040894.eUx3JmxqnP Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 768 On Friday 09 August 2013 13:20:24 Luis Machado wrote: > --- a/gdb/gdbserver/linux-low.c > +++ b/gdb/gdbserver/linux-low.c >=20 > } > -#else > -# define linux_read_loadmap NULL > -#endif /* defined PT_GETDSBT || defined PTRACE_GETFDPIC */ > +#endif /* defined PTRACE_GETFDPIC */ >=20 > @@ -6036,7 +6013,11 @@ static struct target_ops linux_target_ops =3D { > linux_common_core_of_thread, > +#if defined PTRACE_GETFDPIC > linux_read_loadmap, > +#else > + NULL, > +#endif /* defined PTRACE_GETFDPIC */ > linux_process_qsupported, > linux_supports_tracepoints, personally, i liked the style before -- keep the logic where the func is=20 defined rather than in the initialization of the target ops. otherwise, the changes to the linux-low.c file LGTM -mike --nextPart4040894.eUx3JmxqnP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJSGugnAAoJEEFjO5/oN/WBNpwQAI2FUl1Dsdgtn91yLoknLctb j5Zdr0cTjvSwgkWGDRQ6rpM16a7r+/AvRkp6zGA5LMViEtdFsA82K0OoSv81/3ln EvgErb8blAVC2OwA8MHK+txKKRofxl6GM/G9E3Bt6v2zX2dBkv85W9OHvbPKfErU 786dviyX/GVQoAAqYLwHve6AddD6CTGTWsvS7evlEAtPe91tIGo7rW7QQ+QQya+5 dFRvu6lleLcoJmiLG07g+LQdLIYnVyDHX+qlJIAF3t3Vcsu5j6gTuD23/Hd6FCca pDdaQyncG6FeFVfSuWuQKAAXaykK3BacmHoqp+5cJewkF6/5wyNOWoaOFSgowWU2 4jIFTkt3+iO3wHIXqhpV8bwO7wYiRx83UlqN0Zq8ZrG1Ogqctsc59Qb49RwNz3dh snU2XsS2difcGhTcMlqtTqUKApLFNqdBLyGahTi1PSiw51S1kBA9LWVoS6rK+Q6h eaJwJZmaKo2LOsCbeWo+fOTjpa/Iw/n+HPR78fe6JezW0xMfUXis6CuuIxGlVtEe ejJrgMZQyEpRkaJUhIalhUC6jIQcY3u5oE9YUH9R+Y/2s8w4deZLQYExIddvCkXm tcMcljmBV6ECcrGx4LnzvhZa6lywOtTtb4BQuEgSvTacQuYj/BXpHww7NKsp6o+w jBjRVZoXHsH7QEahxUmT =6t8F -----END PGP SIGNATURE----- --nextPart4040894.eUx3JmxqnP--