Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")

Joel Brobecker
2013-08-23T13:34:20Z

> > gdb/ChangeLog:
> >
> > * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
> > instead of "long long" in call to ptrace64.
> >
> > Tested on ppc-aix in full 32bit mode (both GDB and inferior are
> > 32bit). I think the other scenario would be 64bit GDB debugging
> > a 32bit inferior, but I don't have a 64bit compiler to try it.
> >
> > I'd like to commit this patch, unless there are comments/suggestions.
>
> LGTM.

Thanks :)

> Is there a testcase that can be added to the GDB testsuite to catch
> this type of regression?

All testcases involving thread support should reveal this type of
failure. I cannot remember exactly how this patch was tested, but
ISTR that it couldn't be tested through the official testsuite,
for some reasons that were deemed reasonable...

--
Joel