From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104382-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12304 invoked by alias); 18 Aug 2013 19:10:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12290 invoked by uid 89); 18 Aug 2013 19:10:14 -0000
X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 19:10:14 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJA8P1032315	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Sun, 18 Aug 2013 15:10:10 -0400
Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJA44s001143	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Sun, 18 Aug 2013 15:10:07 -0400
Date: Sun, 18 Aug 2013 19:10:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: instruction_history.exp unset variable  [Re: [patch v4 21/24] record-btrace: show trace from enable location]
Message-ID: <20130818191004.GT24153@host2.jankratochvil.net>
References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-22-git-send-email-markus.t.metzger@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1372842874-28951-22-git-send-email-markus.t.metzger@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-08/txt/msg00476.txt.bz2

On Wed, 03 Jul 2013 11:14:31 +0200, Markus Metzger wrote:
> --- a/gdb/testsuite/gdb.btrace/instruction_history.exp
> +++ b/gdb/testsuite/gdb.btrace/instruction_history.exp
> @@ -56,42 +56,42 @@ gdb_test_multiple "info record" $testname {
>      }
>  }
>  
> -# we have exactly 6 instructions here
> -set message "exactly 6 instructions"
> -if { $traced != 6 } {
> +# we have exactly 11 instructions here
> +set message "exactly 11 instructions"
> +if { $traced != 11 } {
>      fail $message
>  } else {
>      pass $message
>  }

Not related to this patch but here is a bug:

set testname "determine number of recorded instructions"
gdb_test_multiple "info record" $testname {
    -re "Active record target: record-btrace\r\nRecorded \(\[0-9\]*\) instructions in \(\[0-9\]*\) functions for thread 1 .*\\.\r\n$gdb_prompt $" {
        set traced $expect_out(1,string)
        set traced_functions $expect_out(2,string)
        pass $testname
    }
}

# we have exactly 11 instructions here
set message "exactly 11 instructions"
if { $traced != 11 } {
[...]

If the first test FAILs then the testcase aborts (aborting also other tests in
its group):

Running ./gdb.btrace/instruction_history.exp ...
FAIL: gdb.btrace/instruction_history.exp: record btrace
FAIL: gdb.btrace/instruction_history.exp: determine number of recorded instructions
ERROR: tcl error sourcing ./gdb.btrace/instruction_history.exp.
ERROR: can't read "traced": no such variable
    while executing
"if { $traced != 11 } {
    fail $message
} else {
    pass $message
}"
[...]


There should be some
	set traced ""
before gdb_test_multiple.
BTW $traced_functions is not used anywhere.


Jan