From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10036 invoked by alias); 18 Aug 2013 19:09:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10027 invoked by uid 89); 18 Aug 2013 19:09:34 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 19:09:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ9VhV004479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 18 Aug 2013 15:09:31 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r7IJ9Q1b009048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 18 Aug 2013 15:09:29 -0400 Date: Sun, 18 Aug 2013 19:09:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [patch v4 22/24] infrun: reverse stepping from unknown functions Message-ID: <20130818190926.GQ24153@host2.jankratochvil.net> References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-23-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372842874-28951-23-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00473.txt.bz2 On Wed, 03 Jul 2013 11:14:32 +0200, Markus Metzger wrote: > When reverse-stepping, only insert a resume breakpoint at ecs->stop_func_start > if the function start is known. Otherwise, keep single-stepping. A testcase would be nice but I understand the fix is obvious so OK without a testcase. > > 2013-07-03 Markus Metzger > > * infrun.c (handle_inferior_event): Check if we know the function > start address. > > > --- > gdb/infrun.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index dc1036d..bd44016 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -4939,7 +4939,7 @@ process_event_stop_test: > or stepped back out of a signal handler to the first instruction > of the function. Just keep going, which will single-step back > to the caller. */ > - if (ecs->stop_func_start != stop_pc) > + if (ecs->stop_func_start != stop_pc && ecs->stop_func_start != 0) > { > struct symtab_and_line sr_sal; > > -- > 1.7.1