From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8568 invoked by alias); 18 Aug 2013 19:09:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8559 invoked by uid 89); 18 Aug 2013 19:09:05 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 19:09:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ93UV028187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 18 Aug 2013 15:09:03 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ8w8s000982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 18 Aug 2013 15:09:01 -0400 Date: Sun, 18 Aug 2013 19:09:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [patch v4 19/24] btrace, linux: fix memory leak when reading branch trace Message-ID: <20130818190857.GO24153@host2.jankratochvil.net> References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-20-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372842874-28951-20-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00471.txt.bz2 On Wed, 03 Jul 2013 11:14:29 +0200, Markus Metzger wrote: > When it takes more than one iteration to read the BTS trace, the trace from the > previous iteration is leaked. Fix it. > > 2013-07-03 Markus Metzger > > * common/linux-btrace.c (linux_read_btrace): Free trace from > previous iteration. > > > --- > gdb/common/linux-btrace.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/gdb/common/linux-btrace.c b/gdb/common/linux-btrace.c > index 4880f41..b30a6ec 100644 > --- a/gdb/common/linux-btrace.c > +++ b/gdb/common/linux-btrace.c > @@ -522,6 +522,9 @@ linux_read_btrace (struct btrace_target_info *tinfo, > { > data_head = header->data_head; > > + /* Delete any leftover trace from the previous iteration. */ > + VEC_truncate (btrace_block_s, btrace, 0); This still leaks, you should do VEC_free. Later you do: *btrace = perf_event_read_bts (tinfo, begin, end, start, size); which overwrites the whole 'struct *' containing validly setup VEC data just with zero elements. > + > /* If there's new trace, let's read it. */ > if (data_head != tinfo->data_head) > { > -- > 1.7.1