From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32347 invoked by alias); 18 Aug 2013 19:06:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32336 invoked by uid 89); 18 Aug 2013 19:06:00 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 19:05:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ5mwa003283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 18 Aug 2013 15:05:49 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ5gMc032627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 18 Aug 2013 15:05:46 -0400 Date: Sun, 18 Aug 2013 19:06:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [patch v4 04/24] record-btrace: fix insn range in function call history Message-ID: <20130818190542.GD24153@host2.jankratochvil.net> References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-5-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372842874-28951-5-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00460.txt.bz2 On Wed, 03 Jul 2013 11:14:14 +0200, Markus Metzger wrote: > With the "/i" modifier, we print the instruction number range in the > "record function-call-history" command as [begin, end). > > It would be more intuitive if we printed the range as [begin, end]. > > 2013-07-03 Markus Metzger > > * record-btrace.c (btrace_call_history_insn_range): Print > insn range as [begin, end]. > > > --- > gdb/record-btrace.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > index 2e7c639..d9a2ba7 100644 > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -425,10 +425,14 @@ static void > btrace_call_history_insn_range (struct ui_out *uiout, > const struct btrace_function *bfun) > { > - unsigned int begin, end; > + unsigned int begin, end, size; > + > + size = VEC_length (btrace_insn_s, bfun->insn); > + if (size == 0) > + return; The current code seems to assert INSN cannot be empty. So 'if (size == 0)' should be replaced by gdb_assert or removed at all. > > begin = bfun->insn_offset; > - end = begin + VEC_length (btrace_insn_s, bfun->insn); > + end = begin + size - 1; > > ui_out_field_uint (uiout, "insn begin", begin); > ui_out_text (uiout, "-"); > -- > 1.7.1