From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29006 invoked by alias); 18 Aug 2013 19:04:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28997 invoked by uid 89); 18 Aug 2013 19:04:13 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 18 Aug 2013 19:04:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ49Ud002575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 18 Aug 2013 15:04:09 -0400 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7IJ45KG028517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 18 Aug 2013 15:04:08 -0400 Date: Sun, 18 Aug 2013 19:04:00 -0000 From: Jan Kratochvil To: Markus Metzger Cc: gdb-patches@sourceware.org Subject: Re: [patch v4 01/24] gdbarch: add instruction predicate methods Message-ID: <20130818190405.GB24153@host2.jankratochvil.net> References: <1372842874-28951-1-git-send-email-markus.t.metzger@intel.com> <1372842874-28951-2-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372842874-28951-2-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-08/txt/msg00458.txt.bz2 On Wed, 03 Jul 2013 11:14:11 +0200, Markus Metzger wrote: [...] > diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh > index c92a857..5b73301 100755 > --- a/gdb/gdbarch.sh > +++ b/gdb/gdbarch.sh > @@ -976,6 +976,15 @@ m:void:iterate_over_objfiles_in_search_order:iterate_over_objfiles_in_search_ord > > # Ravenscar arch-dependent ops. > v:struct ravenscar_arch_ops *:ravenscar_ops:::NULL:NULL::0:host_address_to_string (gdbarch->ravenscar_ops) > + > +# Return non-zero if the instruction at ADDR is a call; zero otherwise. > +M:int:insn_is_call:CORE_ADDR addr:addr::default_insn_is_call > + > +# Return non-zero if the instruction at ADDR is a return; zero otherwise. > +M:int:insn_is_ret:CORE_ADDR addr:addr::default_insn_is_ret > + > +# Return non-zero if the instruction at ADDR is a jump; zero otherwise. > +M:int:insn_is_jump:CORE_ADDR addr:addr::default_insn_is_jump As you no longer use the gdbarch_METHODNAME_p checks if the method is implemented on that gdbarch you can change the initial 'M' to 'm' so that these unused *_p methods are no longer generated. > EOF > } > [...]