Re: [PATCH] Unbuffer stdout and stderr on windows

Pedro Alves
2013-08-28T09:39:05Z

On 08/28/2013 08:22 AM, Yao Qi wrote:

> +/* Create a ui_file from stderr. */
> +

I think this should be in the header....

> +struct ui_file *
> +stderr_fileopen (void)
> +{

> @@ -129,6 +129,9 @@ extern struct ui_file *mem_fileopen (void);
> /* Open/create a STDIO based UI_FILE using the already open FILE. */
> extern struct ui_file *stdio_fileopen (FILE *file);
>
> +extern struct ui_file *stderr_fileopen (void);
> +
> +

... as the other functions (seen from context) are documented here
too.

> /* Open NAME returning an STDIO based UI_FILE. */
> extern struct ui_file *gdb_fopen (const char *name, const char *mode);

> +
> + /* Method 'to_write_async_safe' is not overwritten, because there's
> + no way to flushing a stream in an async-safe manner.

Sorry, my own fault -- should read "to flush".

This is OK with those fixes.

Thanks,
--
Pedro Alves