Re: [PATCH 1/3] Detect GDB is in cygwin

Eli Zaretskii
2013-08-01T16:33:53Z

> Date: Thu, 1 Aug 2013 15:51:23 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: <gdb-patches@sourceware.org>
>
> On 07/30/2013 11:33 PM, Eli Zaretskii wrote:
> > There's no need to probe that at configure time: this code can always
> > be compiled on any MS-Windows system. The compiler doesn't care and
> > doesn't check at compile time whether there is in fact
> > NtQueryInformationFile function inside the DLL.
>
> OK. If so, in configure.ac, we only need to check headers, and don't need
> AC_TRY_COMPILE at all. Here is the updated one, with several changes,
>
> - Remove AC_TRY_COMPILE,
> - Include fewer headers in mingw-htep.c, and don't have to check them
> in configure.ac.
> - Rename is_in_cygwin to using_cygwin_pty,

Thanks. I have just one more request: can you verify that GDB will
not think it runs in a Cygwin pty when it is run from an MSYS Bash
window? (Since MSYS is a fork of an old version of Cygwin, it's
possible that it uses the same template for however it sets up the
shell window.)