Re: [PATCH 1/3] Detect GDB is in cygwin

Christopher Faylor
2013-08-08T05:11:24Z

On Tue, Aug 06, 2013 at 11:04:43AM +0800, Yao Qi wrote:
>On 08/06/2013 10:08 AM, Christopher Faylor wrote:
>> I'm saying that it looks like your code will detect "echo yes | gdb"
>> as running on a cygwin pty.
>
>In this case, the file name of handle looks like
>"\cygwin-c5e39b7a9d22bafb-pipe-0xBC0-0x1". It is expected to return
>true in this case too, that is to say, we need to set stdout/stderr
>unbuffered in this case too.

If you're just going to always set to unbuffered when something
is a pipe, why not just check for a pipe using GetFileType? Then
you don't have to try to use an undocumented Cygwin behaviour.

cgf