Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Yao Qi <yao@codesourcery.com>,
	Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 0/3 V4] Test mingw32 GDB in cygwin
Date: Thu, 15 Aug 2013 17:43:00 -0000	[thread overview]
Message-ID: <20130815174327.GC6955@ednor.casa.cgf.cx> (raw)
In-Reply-To: <83fvudpom7.fsf@gnu.org>

On Tue, Aug 13, 2013 at 07:00:32PM +0300, Eli Zaretskii wrote:
>> From: Yao Qi <yao@codesourcery.com>
>> Date: Tue, 13 Aug 2013 17:34:25 +0800
>> 
>> Here is the V4 of this patch series, which fix problems we've seen on
>> running mingw32 native for testing cygwin.  V3 was reviewed in this thread 
>> http://sourceware.org/ml/gdb-patches/2013-07/msg00691.html by Eli mostly.
>> All the questions/comments were addressed, AFAIK.  However, no one
>> approved it explicitly.  I post them again, and call it V4, which is
>> identical to patches I finally posted in V3 thread.  It is sort of a
>> patch ping.
>
>I suggest to commit this, based on my review, if no one objects in a
>few days.

I'll just register my objection to gdb using undocumented cygwin
internal data representations one more time.

I think that just making pipes unbuffered or using an environment
variable or command-line option is better way to handle this than
assuming that we won't be changing something in Cygwin.

cgf


      reply	other threads:[~2013-08-15 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-13  9:35 Yao Qi
2013-08-13  9:35 ` [PATCH 2/3] Unbuffer stdout and stderr " Yao Qi
2013-08-13  9:35 ` [PATCH 1/3] Detect GDB is " Yao Qi
2013-08-13  9:35 ` [PATCH 3/3] Set stdout/stderr to binary mode " Yao Qi
2013-08-13 16:00 ` [PATCH 0/3 V4] Test mingw32 GDB " Eli Zaretskii
2013-08-15 17:43   ` Christopher Faylor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130815174327.GC6955@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox