From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29232 invoked by alias); 1 Aug 2013 15:54:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29223 invoked by uid 89); 1 Aug 2013 15:54:18 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 15:54:17 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Aug 2013 16:51:19 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 1 Aug 2013 16:51:16 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0D34F219005C for ; Thu, 1 Aug 2013 16:58:24 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r71Frs6N46858384 for ; Thu, 1 Aug 2013 15:53:54 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r71Fs3FX008449 for ; Thu, 1 Aug 2013 09:54:05 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id r71Fs1r9008409; Thu, 1 Aug 2013 09:54:01 -0600 Message-Id: <201308011554.r71Fs1r9008409@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 01 Aug 2013 17:54:01 +0200 Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase To: anton@samba.org (Anton Blanchard) Date: Thu, 01 Aug 2013 15:54:00 -0000 From: "Ulrich Weigand" Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org, brobecker@adacore.com, luis_gustavo@mentor.com In-Reply-To: <20130731223046.292f6a50@kryten> from "Anton Blanchard" at Jul 31, 2013 10:30:46 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13080115-4966-0000-0000-0000067CD65E X-SW-Source: 2013-08/txt/msg00030.txt.bz2 Anton Blanchard wrote: > > This seems to happen because -I option is not passed to the > > assembler. I've tried adding this parameter using -Wa as: > > > > set compile_flags "debug quiet > > additional_flags=-Wa,-I${srcdir}/gdb.asm" > > > > and it fixes the build failure. With this change, the testcase passes > > OK, also including the other 2 patches you sent on this thread. > > Thanks for the fix! Incorporated below. I think it might be best to just get rid of those .include statements; depending on an .inc file from another directory seems surprising. It seems you only need it for the gdbasm_declare macro; since this file is ppc64 specific anyway, why don't you just hard-code the .opd generation in this source file? Also, the assembler source file probably ought to keep the copyright header. A comment why this test needs to use assembler source also would be good. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com