Re: [PATCH] Improve performance of large restore commands

Pedro Alves
2013-07-29T14:14:05Z

On 07/29/2013 06:44 AM, Anton Blanchard wrote:

> 2013-07-29 Anton Blanchard <anton@samba.org>
>
> * target.c (memory_xfer_partial): Cap write to 4K

Period at end of sentence. Might as well write KB :-).

>
> Index: b/gdb/target.c
> ===================================================================
> --- a/gdb/target.c
> +++ b/gdb/target.c
> @@ -1669,6 +1669,13 @@ memory_xfer_partial (struct target_ops *
> void *buf;
> struct cleanup *old_chain;
>
> + /* A large write request is likely to be partially satisfied
> + by memory_xfer_partial_1. We will continually malloc
> + and free a copy of the entire write request for breakpoint
> + shadow handling even though we only end up writing a small
> + subset of it. Cap writes to 4K to mitigate this. */

Double space after all periods, not just the last.

> + len = min(4096, len);

Space before parens:

len = min (4096, len);

Otherwise OK.

Thanks,
--
Pedro Alves