From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12524 invoked by alias); 24 Jul 2013 20:10:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12494 invoked by uid 89); 24 Jul 2013 20:10:40 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Jul 2013 20:10:31 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6OKAMlI030340 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Jul 2013 16:10:22 -0400 Received: from host2.jankratochvil.net (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6OKAHE5012569 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 24 Jul 2013 16:10:20 -0400 Date: Wed, 24 Jul 2013 20:10:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Regression for implptr.exp and pieces.exp [Re: [COMMIT PATCH] value_bits_valid: Fix latent bug.] Message-ID: <20130724201017.GA9015@host2.jankratochvil.net> References: <20130704160927.11801.10290.stgit@brno.lan> <51D6DB44.1000609@broadcom.com> <51D6E0EB.3040006@redhat.com> <51D6E441.4040709@broadcom.com> <51D70EBB.4050505@redhat.com> <51DA92D9.8050408@broadcom.com> <20130709095442.GA20006@host2.jankratochvil.net> <51DC1B1A.5090203@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DC1B1A.5090203@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-07/txt/msg00582.txt.bz2 On Tue, 09 Jul 2013 16:15:54 +0200, Andrew Burgess wrote: > On 09/07/2013 10:54 AM, Jan Kratochvil wrote: > > 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 is the first bad commit > > commit 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 > > Author: aburgess > > Date: Mon Jul 8 10:21:33 2013 +0000 > > > > Fix bug in value_bits_valid. > > > > http://sourceware.org/ml/gdb-patches/2013-07/msg00174.html > > > > * value.c (value_bits_valid): If the value is not lval_computed > > or has no check validity handler then the answer is the > > optimized_out flag, otherwise defer to the handler. > > > > Running gdb/testsuite/gdb.dwarf2/implptr.exp ... > > -PASS: gdb.dwarf2/implptr.exp: print j in implptr:bar > > +FAIL: gdb.dwarf2/implptr.exp: print j in implptr:bar > > -PASS: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo > > +FAIL: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo > > > > Running gdb/testsuite/gdb.dwarf2/pieces.exp ... > > -PASS: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 > > -PASS: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 > > -PASS: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 > > -PASS: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 > > +FAIL: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 > > +FAIL: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 > > +FAIL: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 > > +FAIL: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 > > I've committed a patch to revert all the changes done by Pedro and > myself to value_bits_valid, Confirming the temporary regression has been fixed by: commit 34b2792f3cdf8d24d665257b56c6c576a8dfa27c Author: aburgess Date: Tue Jul 9 14:11:53 2013 +0000 Revert recent changes to value_bits_valid. http://sourceware.org/ml/gdb-patches/2013-07/msg00243.html * value.c (value_bits_valid): Revert previous change, and change by Pedro on 2013-07-04, due to regressions in gdb.dwarf2/implptr.exp and gdb.dwarf2/pieces.exp. Jan