From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21215 invoked by alias); 18 Jul 2013 13:28:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21190 invoked by uid 89); 18 Jul 2013 13:28:37 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Jul 2013 13:28:35 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r6IDSN5Y015232; Thu, 18 Jul 2013 15:28:23 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r6IDSN73029313; Thu, 18 Jul 2013 15:28:23 +0200 (CEST) Date: Thu, 18 Jul 2013 13:28:00 -0000 Message-Id: <201307181328.r6IDSN73029313@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: nicolas.blanc@intel.com CC: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org, dje@google.com In-reply-to: <388084C8C1E6A64FA36AD1D656E485661A7B11F5@IRSMSX106.ger.corp.intel.com> (nicolas.blanc@intel.com) Subject: Re: [PATCH v12 5/5] Test adding and removing a symbol file at runtime. References: <1374078455-906-1-git-send-email-nicolas.blanc@intel.com> <1374078455-906-6-git-send-email-nicolas.blanc@intel.com> <201307171852.r6HIquNI026465@glazunov.sibelius.xs4all.nl> <388084C8C1E6A64FA36AD1D656E485661A7B11F5@IRSMSX106.ger.corp.intel.com> X-SW-Source: 2013-07/txt/msg00447.txt.bz2 > From: "Blanc, Nicolas" > Date: Thu, 18 Jul 2013 12:51:48 +0000 > > >> +#include > > > >The header isn't standardized at all. So this testcase > >probably only compile on systems that use glibc as their C library. > >Might not even work on a significant fraction of systems that use a > >Linux kernel. > > > >Perhaps it is possible to use the headers from include/elf in the > >src tree instead? > > Thanks Mark of looking into this patch. I can change the include, no > big deal, but looks more portable to me than > for the following reasons: I wasn't suggesting to use /usr/include/elf.h, but rather the header files in $(srcdir)/../include/elf. > * The man pages for Linux and FreeBSD both mention but not > * : > http://man7.org/linux/man-pages/man5/elf.5.html > http://www.freebsd.org/cgi/man.cgi?query=elf&sektion=5&apropos=0&manpath=FreeBSD+9.1-RELEASE > > I could compile the test on following distros: Fedora 15, Red Hat > 6.2, Ubuntu 12.4, and SUSE 11.1. And is even available on > Cygwin. It's not available on OpenBSD and NetBSD, although we have a somewhat similar header called on OpenBSD (and probably on NetBSD too). But even on the platforms that do have its contents aren't completely standardized. So you'll need to be very careful with what defenitions you use. That's why I'm suggesting to use a header provided by gdb (or rather BFD) itself as. > * The following GDB tests include : > ./gdb.arch/ppc-dfp.c:#include > ./gdb.base/jit-main.c:#include Didn't catch the ppc-dfp.c test yet, since it runs only on PowerPC. The problems with jit-main.c is the reason why I pointed this out to you ;).