From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23042 invoked by alias); 17 Jul 2013 18:43:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23017 invoked by uid 89); 17 Jul 2013 18:43:51 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Jul 2013 18:43:51 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id r6HIhXmA017096; Wed, 17 Jul 2013 20:43:33 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id r6HIhWEQ006115; Wed, 17 Jul 2013 20:43:32 +0200 (CEST) Date: Wed, 17 Jul 2013 18:43:00 -0000 Message-Id: <201307171843.r6HIhWEQ006115@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: nicolas.blanc@intel.com CC: gdb-patches@sourceware.org, dje@google.com, nicolas.blanc@intel.com In-reply-to: <1374078455-906-5-git-send-email-nicolas.blanc@intel.com> (message from Nicolas Blanc on Wed, 17 Jul 2013 18:27:34 +0200) Subject: Re: [PATCH v12 4/5] Function is_elf_target. References: <1374078455-906-1-git-send-email-nicolas.blanc@intel.com> <1374078455-906-5-git-send-email-nicolas.blanc@intel.com> X-SW-Source: 2013-07/txt/msg00413.txt.bz2 > From: Nicolas Blanc > Date: Wed, 17 Jul 2013 18:27:34 +0200 > > 2013-17-07 Nicolas Blanc > > gdb/testsuite > * lib/gdb.exp (is_elf_target): New function. > > Signed-off-by: Nicolas Blanc That's a very incomplete list. I think a better solution is needed. Instead of whitelisting targets for what is basically the default, blacklisting targets that aren't ELF would be a better approach. > --- > gdb/testsuite/lib/gdb.exp | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 376aacc..8c5cdb5 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -1782,6 +1782,21 @@ proc supports_reverse {} { > return 0 > } > > +# Return 1 if target supports ELF. > +proc is_elf_target {} { > + > + if { [istarget "*-*-linux*"] > + || [istarget "*-*-gnu*"] > + || [istarget "*-*-elf*"] > + || [istarget "arm*-*-eabi*"] > + || [istarget "arm*-*-symbianelf*"] > + || [istarget "powerpc-*-eabi*"] } { > + return 1 > + } > + > + return 0 > +} > + > # Return 1 if target is ILP32. > # This cannot be decided simply from looking at the target string, > # as it might depend on externally passed compiler options like -m64. > -- > 1.7.6.5 > >