From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: "Agovic, Sanimir" <sanimir.agovic@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Cary Coutant <ccoutant@google.com>,
Sterling Augustine <saugustine@google.com>
Subject: Re: [patchv2 1/11] Remove xfullpath (use gdb_realpath instead)
Date: Wed, 17 Jul 2013 16:51:00 -0000 [thread overview]
Message-ID: <20130717165045.GA7275@host2.jankratochvil.net> (raw)
In-Reply-To: <CADPb22SG24NvuUzRENYDT2QnEr7n+2cTtfErj1nPKBxFs9tFZA@mail.gmail.com>
On Wed, 17 Jul 2013 18:12:53 +0200, Doug Evans wrote:
> Ah, forgot a reason. [How not unexpected, sigh.]
>
> If a binary has an auxiliary file (e.g., a separate debug info file or
> a -gdb.py file) then gdb won't be able to find them - the auxiliary
> files could be named and/or located based on the realpath name.
In general GDB does many comparison for file identity by:
strcmp (xfullpath (a), xfullpath (b)) == 0
It would be much more efficient to do:
stat (a).st_{dev,ino} == stat (b).st_{dev,ino}
Going to check what to do with the argv[0] problem, there seems to be xfullpath
excessive.
I do not know what happens with ${binary}.dwp. But .debug files were always
symlinked similar way to their original binary files:
lrwxrwxrwx 1 root root 27 Jun 19 00:23 /lib64/libgtk-x11-2.0.so -> libgtk-x11-2.0.so.0.2400.19*
lrwxrwxrwx 1 root root 27 Jun 19 00:23 /lib64/libgtk-x11-2.0.so.0 -> libgtk-x11-2.0.so.0.2400.19*
-rwxr-xr-x 1 root root 4779088 Jun 16 22:05 /lib64/libgtk-x11-2.0.so.0.2400.19*
lrwxrwxrwx 1 root root 33 Jun 19 00:23 /usr/lib/debug/lib64/libgtk-x11-2.0.so.debug -> libgtk-x11-2.0.so.0.2400.19.debug
lrwxrwxrwx 1 root root 33 Jun 19 00:23 /usr/lib/debug/lib64/libgtk-x11-2.0.so.0.debug -> libgtk-x11-2.0.so.0.2400.19.debug
-r--r--r-- 1 root root 13663732 Jun 16 22:05 /usr/lib/debug/lib64/libgtk-x11-2.0.so.0.2400.19.debug
So I would say this is a bug in the script generating *.dwp, isn't it?
Jan
next prev parent reply other threads:[~2013-07-17 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 22:31 Jan Kratochvil
2013-02-03 15:55 ` [commit] " Jan Kratochvil
2013-07-17 12:49 ` Agovic, Sanimir
2013-07-17 16:04 ` Doug Evans
2013-07-17 16:13 ` Doug Evans
2013-07-17 16:51 ` Jan Kratochvil [this message]
2013-07-17 17:24 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717165045.GA7275@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sanimir.agovic@intel.com \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox