From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24493 invoked by alias); 11 Jul 2013 16:45:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24484 invoked by uid 89); 11 Jul 2013 16:45:22 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Jul 2013 16:45:21 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2FB691C680F; Thu, 11 Jul 2013 12:45:20 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Us5xN1cublVj; Thu, 11 Jul 2013 12:45:20 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F38FE1C66B0; Thu, 11 Jul 2013 12:45:19 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4B09FC0F18; Thu, 11 Jul 2013 09:45:18 -0700 (PDT) Date: Thu, 11 Jul 2013 16:45:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA] bad VER in src-release causes snapshot failure Message-ID: <20130711164518.GJ8063@adacore.com> References: <20130711153403.GH8063@adacore.com> <87oba9dqba.fsf@fleche.redhat.com> <20130711164204.GI8063@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130711164204.GI8063@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-07/txt/msg00326.txt.bz2 > Either works for me. Your version has the downside of computing > the GDB version even if not trying to build a GDB package, and > it could also open the door for us forgetting to set VER to > GDB_VER. On the upside, it does avoid putting some GDB-specific > code in an expression which is otherwise pretty generic (expression > computing VER). I also meant to mention that my patch avoids duplicating again the code used to compute the GDB version... It's already spread everywhere, so not a big deal, but relatively easy to avoid by re-using your create-version.sh script. A bit of a hack, though. -- Joel