From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] bad VER in src-release causes snapshot failure
Date: Thu, 11 Jul 2013 16:42:00 -0000 [thread overview]
Message-ID: <20130711164204.GI8063@adacore.com> (raw)
In-Reply-To: <87oba9dqba.fsf@fleche.redhat.com>
> >>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>
> Joel> * src-release (VER): Use $(TOOL)/common/create-version.sh
> Joel> if it exists.
>
> I sent one a while ago, was hoping for a review:
> http://sourceware.org/ml/gdb-patches/2013-06/msg00738.html
Either works for me. Your version has the downside of computing
the GDB version even if not trying to build a GDB package, and
it could also open the door for us forgetting to set VER to
GDB_VER. On the upside, it does avoid putting some GDB-specific
code in an expression which is otherwise pretty generic (expression
computing VER).
--
Joel
next prev parent reply other threads:[~2013-07-11 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 15:34 Joel Brobecker
2013-07-11 16:17 ` Tom Tromey
2013-07-11 16:42 ` Joel Brobecker [this message]
2013-07-11 16:45 ` Joel Brobecker
2013-07-13 15:03 ` Tom Tromey
2013-07-22 15:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711164204.GI8063@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox