From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
Cc: raunaq12@in.ibm.com, gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [PATCH 3/5] powerpc64-aix inf-ptrace patch
Date: Wed, 10 Jul 2013 19:07:00 -0000 [thread overview]
Message-ID: <201307101907.r6AJ7AfX021641@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <87r4f6fgst.fsf@fleche.redhat.com> (message from Tom Tromey on Wed, 10 Jul 2013 11:47:30 -0600)
> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 10 Jul 2013 11:47:30 -0600
>
> >>>>> ">" == Raunaq 12 <raunaq12@in.ibm.com> writes:
>
> >> Since that is not the right way to go about it, I thought it would be
> >> better to create a new file called 'inf-ptrace64.c' derived from
> >> inf-ptrace instead, This new file contains all these above mentioned
> >> changes. inf-ptrace64 will be compiled only if the host is detected
> >> as powerpc64-ibm-aix. SO, it will not interfere with the original
> >> inf-ptrace that is used if host is powerpc-ibm-aix
>
> No, copying the file is worse than other available alternatives.
> For example you can use configure to discover the proper argument types,
> and then write a function that wraps ptrace and provides the needed
> casts.
I agree that copying inf-ptrace.c isn't the right approach. Tom's
suggestion might be viable, but I wouldn't be pleased with more magic
casts and #ifdefs in inf-ptrace.c.
next prev parent reply other threads:[~2013-07-10 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 9:15 Raunaq 12
2013-07-10 17:47 ` Tom Tromey
2013-07-10 19:07 ` Mark Kettenis [this message]
2013-07-15 7:32 ` Raunaq 12
2013-07-15 9:12 ` Mark Kettenis
2013-07-16 10:48 ` Raunaq 12
2013-07-23 5:35 Raunaq 12
2013-07-23 9:01 ` Mark Kettenis
2013-07-23 12:57 ` Raunaq 12
2013-07-23 14:25 ` Mark Kettenis
2013-07-23 19:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307101907.r6AJ7AfX021641@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=raunaq12@in.ibm.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox