From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16251 invoked by alias); 9 Jul 2013 09:54:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16198 invoked by uid 89); 9 Jul 2013 09:54:52 -0000 X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 09 Jul 2013 09:54:50 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r699sm2n030054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Jul 2013 05:54:48 -0400 Received: from host2.jankratochvil.net (ovpn-116-83.ams2.redhat.com [10.36.116.83]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r699shYh030681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 9 Jul 2013 05:54:46 -0400 Date: Tue, 09 Jul 2013 09:54:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Regression for implptr.exp and pieces.exp [Re: [COMMIT PATCH] value_bits_valid: Fix latent bug.] Message-ID: <20130709095442.GA20006@host2.jankratochvil.net> References: <20130704160927.11801.10290.stgit@brno.lan> <51D6DB44.1000609@broadcom.com> <51D6E0EB.3040006@redhat.com> <51D6E441.4040709@broadcom.com> <51D70EBB.4050505@redhat.com> <51DA92D9.8050408@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DA92D9.8050408@broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-07/txt/msg00243.txt.bz2 On Mon, 08 Jul 2013 12:22:17 +0200, Andrew Burgess wrote: > On 05/07/2013 7:21 PM, Pedro Alves wrote: > > On 07/05/2013 04:20 PM, Andrew Burgess wrote: > > > >> 2013-07-05 Andrew Burgess > >> > >> * value.c (value_bits_valid): If the value is not lval_computed > >> or has no check validity handler then the answer is the > >> optimized_out flag, otherwise defer to the handler. > > > > OK. > > Committed. On any platform I test for 32-bit targets (either on i386 native host or on x86_64 host with -m32 target cflags) I get: 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 is the first bad commit commit 9f5e30f7cf73a3256fbb9a265c897aa3f2c91439 Author: aburgess Date: Mon Jul 8 10:21:33 2013 +0000 Fix bug in value_bits_valid. http://sourceware.org/ml/gdb-patches/2013-07/msg00174.html * value.c (value_bits_valid): If the value is not lval_computed or has no check validity handler then the answer is the optimized_out flag, otherwise defer to the handler. Running gdb/testsuite/gdb.dwarf2/implptr.exp ... -PASS: gdb.dwarf2/implptr.exp: print j in implptr:bar +FAIL: gdb.dwarf2/implptr.exp: print j in implptr:bar -PASS: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo +FAIL: gdb.dwarf2/implptr.exp: print p[0].x in implptr:foo Running gdb/testsuite/gdb.dwarf2/pieces.exp ... -PASS: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 -PASS: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 -PASS: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 -PASS: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 +FAIL: gdb.dwarf2/pieces.exp: print a.i in pieces:f3 +FAIL: gdb.dwarf2/pieces.exp: print a.j in pieces:f3 +FAIL: gdb.dwarf2/pieces.exp: set a.i in pieces:f3 +FAIL: gdb.dwarf2/pieces.exp: print new a.i in pieces:f3 Regards, Jan