From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7717 invoked by alias); 4 Jul 2013 13:22:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7673 invoked by uid 89); 4 Jul 2013 13:22:48 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from e06smtp18.uk.ibm.com (HELO e06smtp18.uk.ibm.com) (195.75.94.114) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 04 Jul 2013 13:22:46 +0000 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Jul 2013 14:17:07 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp18.uk.ibm.com (192.168.101.148) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 4 Jul 2013 14:17:06 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 003742190059 for ; Thu, 4 Jul 2013 14:26:29 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r64DMVfD57606266 for ; Thu, 4 Jul 2013 13:22:31 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r64DMfGH026895 for ; Thu, 4 Jul 2013 07:22:42 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id r64DMeIf026838; Thu, 4 Jul 2013 07:22:40 -0600 Message-Id: <201307041322.r64DMeIf026838@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 04 Jul 2013 15:22:39 +0200 Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. To: lgustavo@codesourcery.com Date: Thu, 04 Jul 2013 13:22:00 -0000 From: "Ulrich Weigand" Cc: palves@redhat.com (Pedro Alves), tromey@redhat.com (Tom Tromey), stanshebs@earthlink.net (Stan Shebs), gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <51D47A05.9020404@codesourcery.com> from "Luis Machado" at Jul 03, 2013 04:22:45 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13070413-6892-0000-0000-000005994C76 X-SW-Source: 2013-07/txt/msg00171.txt.bz2 Luis Machado wrote: > On 07/03/2013 12:05 PM, Pedro Alves wrote: > > On 07/02/2013 07:50 PM, Luis Machado wrote: > >> - > >> -if {[istarget "spu*-*-*"]} then { > >> - # The internal address format used for the combined Cell/B.E. > >> - # debugger requires 64-bit. > >> - set is64bitonly "yes" > >> -} > >> - > > > > I'm not sure this equates to sizeof pointer == 64-bit. > > This bit may need to be retained. [Adding Ulrich]. > > Fair enough. Ulrich, let me know if the pointer check in the attached > patch doesn't make sense for Cell BE. No, the pointer check is not enough. The problem is that on Cell/B.E., GDB uses a (purely internal to GDB) address format to encode multiple address spaces into a synthetic GDB address space. See the long comment in spu-tdep.h for details. The "restore" command needs a full internal 64-bit address on Cell/B.E. to uniquely identify the location where to restore memory. Thus using a data format that can only remember 32-bit addresses don't work: http://sourceware.org/ml/gdb-patches/2008-09/msg00139.html However, just testing the size of a pointer will return 32-bit on SPU, because that's the ABI-defined pointer size (the 64 bits are purely GDB internal). So I think Cell/B.E. / SPU will need to remain a special case here for now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com