From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103168-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10897 invoked by alias); 3 Jul 2013 09:00:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 10887 invoked by uid 89); 3 Jul 2013 09:00:35 -0000
X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Jul 2013 09:00:34 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6390SB2031199	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 3 Jul 2013 05:00:33 -0400
Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6390J6k008433	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 3 Jul 2013 05:00:23 -0400
Date: Wed, 03 Jul 2013 09:00:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Build regression on CentOS-5  [Re: [PATCH 3/3] add -Wold-style-definition]
Message-ID: <20130703090018.GA1009@host2.jankratochvil.net>
References: <1371494572-26594-1-git-send-email-tromey@redhat.com> <1371494572-26594-4-git-send-email-tromey@redhat.com> <20130702080754.GA24111@host2.jankratochvil.net> <87hagcela1.fsf@fleche.redhat.com> <87a9m4el8y.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87a9m4el8y.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-07/txt/msg00108.txt.bz2

On Tue, 02 Jul 2013 22:54:05 +0200, Tom Tromey wrote:
> @@ -1580,6 +1582,17 @@ printcmd.o: $(srcdir)/printcmd.c
>  		$(COMPILE.post) $(srcdir)/printcmd.c
>  	$(POSTCOMPILE)
>  
> +# ada-exp.c can appear in srcdir, for releases; or in ., for
> +# development builds.
> +ADA_EXP_C = `if test -f ada-exp.c; then echo ada-exp.c; else echo $(srcdir)/ada-exp.c; fi`
> +
> +# Some versions of flex give output that triggers
> +# -Wold-style-definition.
> +ada-exp.o: ada-exp.c
> +	$(COMPILE.pre) $(INTERNAL_CFLAGS) $(GDB_WARN_CFLAGS_NO_DEFS) \
> +		$(COMPILE.post) $(ADA_EXP_C)

I would find easier: s/$(ADA_EXP_C)/$</ and remove ADA_EXP_C = above.
Or is that for non-GNU make without VPATH?  But non-VPATH make would IMO fail
on missing pre-requisite file ada-exp.c.

I do not mind either way.


> +	$(POSTCOMPILE)
> +
>  # Message files.  Based on code in gcc/Makefile.in.
>  
>  # Rules for generating translated message descriptions.  Disabled by


Thanks,
Jan