From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5830 invoked by alias); 1 Jul 2013 08:19:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5779 invoked by uid 89); 1 Jul 2013 08:19:28 -0000 X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Jul 2013 08:19:27 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r618JQc6010150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Jul 2013 04:19:26 -0400 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r618JMSb002970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 1 Jul 2013 04:19:25 -0400 Date: Mon, 01 Jul 2013 08:19:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [patch] testsuite build regression on CentOS-5 [Re: [PATCH 1/7] test suite update - gdb.base/[ab]] Message-ID: <20130701081922.GA11655@host2.jankratochvil.net> References: <1371675821-9959-1-git-send-email-tromey@redhat.com> <1371675821-9959-2-git-send-email-tromey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371675821-9959-2-git-send-email-tromey@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-07/txt/msg00020.txt.bz2 On Wed, 19 Jun 2013 23:03:35 +0200, Tom Tromey wrote: > --- a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp > +++ b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp [...] > set additional_flags {-ffunction-sections -Wl,--gc-sections} > -if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \ > - [list debug c++ additional_flags=$additional_flags]] != "" } { > - untested $srcfile > +if {[prepare_for_testing $testfile.exp $testfile $srcfile \ > + [list debug c++ additional_flags=$additional_flags]]} { > + untested $testfile.exp > return -1 > } Running gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp ... -PASS: gdb.base/break-on-linker-gcd-function.exp: b 24 +gdb compile failed, g++: --gc-sections: linker input file unused because linking not done +UNTESTED: gdb.base/break-on-linker-gcd-function.exp: break-on-linker-gcd-function.exp +UNTESTED: gdb.base/break-on-linker-gcd-function.exp: break-on-linker-gcd-function.exp Retested it still FAILs with the unfixed GDB. I will check it in. Jan gdb/testsuite/ 2013-07-01 Jan Kratochvil * gdb.base/break-on-linker-gcd-function.exp: Replace prepare_for_testing by build_executable_from_specs and clean_restart. diff --git a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp index 7a4ef83..f9b844f 100644 --- a/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp +++ b/gdb/testsuite/gdb.base/break-on-linker-gcd-function.exp @@ -32,12 +32,15 @@ if [get_compiler_info "c++"] { } set additional_flags {-ffunction-sections -Wl,--gc-sections} -if {[prepare_for_testing $testfile.exp $testfile $srcfile \ - [list debug c++ additional_flags=$additional_flags]]} { +if {[build_executable_from_specs $testfile.exp $testfile \ + {c++ additional_flags=-Wl,--gc-sections} \ + $srcfile {debug c++ additional_flags=-ffunction-sections}]} { untested $testfile.exp return -1 } +clean_restart $testfile + # Single hex digit set xd {[0-9a-f]}