From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11018 invoked by alias); 26 Jun 2013 18:53:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11009 invoked by uid 89); 26 Jun 2013 18:53:40 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 26 Jun 2013 18:53:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1C15032A50; Wed, 26 Jun 2013 14:53:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oF6gIGlbMDRg; Wed, 26 Jun 2013 14:53:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C70AD32A4F; Wed, 26 Jun 2013 14:53:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C6E1DC9D74; Wed, 26 Jun 2013 11:53:35 -0700 (PDT) Date: Wed, 26 Jun 2013 19:15:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org, Jan Kratochvil , Pedro Alves Subject: Re: [commit] Improved linker-debugger interface Message-ID: <20130626185335.GJ5326@adacore.com> References: <20130516144340.GA2105@blade.nx> <20130604133819.GA25892@blade.nx> <20130625205350.GA28973@adacore.com> <87hagkrih3.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00793.txt.bz2 > What could be done is to check gdbarch_stap_is_single_operand_p. This > is a mandatory function that needs to be set by the target. If it > doesn't exist, then we know that the target lacks SDT support. > > Before I work on a patch, I'd like to know what you think. I agree that it would be friendlier to make sure stap-support is activated before trying to use it. If the warning is then only possible when stap support is in, and denotes a bug in either GDB or the executable, then I'm all for keeping it. I also like Tom's suggestion of expanding the warning to contain the pieces of information he suggested. I had a recent experience where the warning was missing a critical piece of information and that prevented me from diagnosing the problem remotely. -- Joel