From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12562 invoked by alias); 25 Jun 2013 15:51:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12551 invoked by uid 89); 25 Jun 2013 15:51:41 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 15:51:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFpcvw013274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Jun 2013 11:51:39 -0400 Received: from pinnacle.lan (ovpn-113-152.phx2.redhat.com [10.3.113.152]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PFpb6Y008929 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 25 Jun 2013 11:51:38 -0400 Date: Tue, 25 Jun 2013 15:55:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFC] TI msp430 architecture support Message-ID: <20130625085137.4317c9b8@pinnacle.lan> In-Reply-To: <87txkmtghb.fsf@fleche.redhat.com> References: <20130516200050.17ab3ae7@mesquite.lan> <20130517062911.GE4017@adacore.com> <20130624185342.29e671a3@pinnacle.lan> <87txkmtghb.fsf@fleche.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00717.txt.bz2 On Tue, 25 Jun 2013 08:25:20 -0600 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner writes: > > Kevin> I fixed the formatting issues that you noticed and then, for > Kevin> good measure, I ran the file through gdb_indent.sh. I should've > Kevin> run gdb_indent.sh over msp430-tdep.c prior to submitting it. > > I didn't know anybody used gdb_indent.sh. Was this a one-off thing or > have you run it regularly on other source files? There was a time when the output of GNU indent was considered the standard for GDB indentation. If there was any disagreement about correct indentation, a contributor would be asked to run GNU indent over the code. The problem is, of course, that different options produce different results which is how gdb_indent.sh came into being. My recollection is that there were at least two occasions when significant portions of the gdb source tree were reindented. (This may have pre-dated the creation of gdb_indent.sh, however.) I don't think that mass reindentation should be done very often because it causes a lot more work for folks who have developed significant changes prior to the the reindenation occurring. I think it can make sense for newly contributed files, however. Kevin