Re: [PATCH 1/5] Share 'enum target_hw_bp_type' in GDB and GDBserver.

Tom Tromey
2013-07-24T14:04:00Z

>>>>> "Maciej" == Maciej W Rozycki <macro@codesourcery.com> writes:

Maciej> On Sat, 29 Jun 2013, Yao Qi wrote:
>> 'enum target_hw_bp_type' has been used in both GDB and GDBserver. It
>> will be used in MIPS hardware watchpoint support too. This patch
>> is to share 'enum target_hw_bp_type' in common/break-common.h.

Maciej> FWIW this patch looks reasonable to me, though I can't approve
Maciej> or reject a generic change like this. I can see
Maciej> gdb/gdbserver/linux-aarch64-low.c has a similar
Maciej> target_point_type enum. It might be a good idea to unify them
Maciej> all.

This patch is ok.

Tom