Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/

Joel Brobecker
2013-06-20T17:28:51Z

> > If we put the prototypes into a single line, the length exceeds the
> > 74-character limit. This is the reason I moved parameter "set" to a new line.
> > Shall we keep them as what they are now?
>
> There's no 74-character limit for code, all you need is to stay
> within 79 columns. Did you apply the ChangeLog rule here?

Actually, the last time we discussed maximum code line length,
we settled on 70 characters.

Reference: http://www.sourceware.org/ml/gdb-patches/2011-01/msg00035.html

It's not consistent across files; for instance, it's 74 characters
in ChangeLogs. Those limits are kind of arbitrary, but I do find 79
characters to be slightly harder to read. Jan recently opened that
discussion again, and proposed 80 characters, but that did not stick.
I proposed to standardize on 74 instead, which is already the default
for some editors and the value used for ChangeLogs. But the discussion
then died. I'm not too surprised, since it's impossible to please
everybody, and controversial changes in the GDB porject have a tendency
of getting stuck.

--
Joel