From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7397 invoked by alias); 21 Jun 2013 11:43:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7378 invoked by uid 89); 21 Jun 2013 11:43:22 -0000 X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 21 Jun 2013 11:43:22 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5LBhIc6002266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Jun 2013 07:43:18 -0400 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5LBhDBg003534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 21 Jun 2013 07:43:16 -0400 Date: Fri, 21 Jun 2013 12:56:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: Joel Brobecker , "gdb-patches@sourceware.org" , "Pedro Alves (palves@redhat.com)" Subject: Re: [patch] Fix cleanup in finish_command Message-ID: <20130621114313.GA5381@host2.jankratochvil.net> References: <20130619211444.GA29379@host2.jankratochvil.net> <20130620143118.GA11929@host2.jankratochvil.net> <20130620151806.GD4724@adacore.com> <20130620161945.GA16142@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-06/txt/msg00587.txt.bz2 On Fri, 21 Jun 2013 10:03:21 +0200, Metzger, Markus T wrote: > > Unrelated: > > There is testcase FAILing randomly, reproducible with "read1.so" from: > > http://sourceware.org/bugzilla/show_bug.cgi?id=12649 > > Running ./gdb.btrace/exception.exp ... > > FAIL: gdb.btrace/exception.exp: exception - flat (timeout) > > I do not think that this is an actual issue. It runs into a timeout because > there is so much memory to read. > > When I add to my board file: > > set_board_info gdb,timeout 8000 > > it takes a very long time, but the test eventually passes. BTW the testcase is still not right, sometimes it fails due to: ERROR: internal buffer is full. ERROR: internal buffer is full. (This is why I tried the "read1" reproducer for it...) One can either increase the expect buffer size or rather use appropriate lib/gdb.exp function for it. To be just merged into the patchset I think. Regards, Jan diff --git a/gdb/testsuite/gdb.btrace/exception.exp b/gdb/testsuite/gdb.btrace/exception.exp index a8da2b0..430c84b 100644 --- a/gdb/testsuite/gdb.btrace/exception.exp +++ b/gdb/testsuite/gdb.btrace/exception.exp @@ -44,24 +44,28 @@ gdb_test_no_output "record btrace" gdb_continue_to_breakpoint "cont to $bp_2" ".*$srcfile:$bp_2.*" # show the flat branch trace -gdb_test "record function-call-history 1" " +send_gdb "record function-call-history 1\n" +gdb_expect_list "exception - flat" "\r\n$gdb_prompt $" { "\r 1\tmain\\(\\)\r 2\ttest\\(\\)\r 3\tfoo\\(\\)\r 4\tbar\\(\\)\r 5\tbad\\(\\)\r -.*\r -\[0-9\]*\ttest\\(\\)" "exception - flat" +" + "\r\n\[0-9\]*\ttest\\(\\)" +} # show the branch trace with calls indented # # here we see a known bug that the indentation starts at level 1 with # two leading spaces instead of level 0 without leading spaces. -gdb_test "record function-call-history /c 1" " +send_gdb "record function-call-history /c 1\n" +gdb_expect_list "exception - calls indented" "\r\n$gdb_prompt $" { "\r 1\tmain\\(\\)\r 2\t test\\(\\)\r 3\t foo\\(\\)\r 4\t bar\\(\\)\r 5\t bad\\(\\)\r -.*\r -\[0-9\]*\t test\\(\\)" "exception - calls indented" +" + "\r\n\[0-9\]*\t test\\(\\)" +}