From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2096 invoked by alias); 20 Jun 2013 17:28:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2074 invoked by uid 89); 20 Jun 2013 17:28:49 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 17:28:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C475F1C662E; Thu, 20 Jun 2013 13:28:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aYnUVXI7xgVx; Thu, 20 Jun 2013 13:28:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 937BB1C660B; Thu, 20 Jun 2013 13:28:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 81E4FC2B5F; Thu, 20 Jun 2013 10:28:44 -0700 (PDT) Date: Thu, 20 Jun 2013 17:50:00 -0000 From: Joel Brobecker To: "Maciej W. Rozycki" Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/ Message-ID: <20130620172844.GE4724@adacore.com> References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1369881867-11372-3-git-send-email-yao@codesourcery.com> <51B93F00.5090002@codesourcery.com> <51C305F0.90008@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00552.txt.bz2 > > If we put the prototypes into a single line, the length exceeds the > > 74-character limit. This is the reason I moved parameter "set" to a new line. > > Shall we keep them as what they are now? > > There's no 74-character limit for code, all you need is to stay > within 79 columns. Did you apply the ChangeLog rule here? Actually, the last time we discussed maximum code line length, we settled on 70 characters. Reference: http://www.sourceware.org/ml/gdb-patches/2011-01/msg00035.html It's not consistent across files; for instance, it's 74 characters in ChangeLogs. Those limits are kind of arbitrary, but I do find 79 characters to be slightly harder to read. Jan recently opened that discussion again, and proposed 80 characters, but that did not stick. I proposed to standardize on 74 instead, which is already the default for some editors and the value used for ChangeLogs. But the discussion then died. I'm not too surprised, since it's impossible to please everybody, and controversial changes in the GDB porject have a tendency of getting stuck. -- Joel