From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25364 invoked by alias); 19 Jun 2013 15:20:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25321 invoked by uid 89); 19 Jun 2013 15:20:52 -0000 X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 15:20:51 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 1E69E33E600; Wed, 19 Jun 2013 15:20:50 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v3] gdb: clean up x86 cpuid implementations Date: Wed, 19 Jun 2013 15:50:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201305061451.24861.vapier@gentoo.org> <201306191053.51709.vapier@gentoo.org> <51C1C8D5.5080809@redhat.com> In-Reply-To: <51C1C8D5.5080809@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2779247.Wm6TSe28zZ"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201306191120.52053.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00496.txt.bz2 --nextPart2779247.Wm6TSe28zZ Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 2334 On Wednesday 19 June 2013 11:05:57 Pedro Alves wrote: > On 06/19/2013 03:53 PM, Mike Frysinger wrote: > > On Wednesday 19 June 2013 07:43:42 Pedro Alves wrote: > >> On 06/19/2013 03:46 AM, Mike Frysinger wrote: > >>=20 > >> However, BTW, I failed to notice this before, but: > >>> +++ b/gdb/common/i386-cpuid.h > >>> @@ -0,0 +1,68 @@ > >>> +/* > >>> + * Copyright (C) 2007-2013 Free Software Foundation, Inc. > >>> + * > >>> + * This file is free software; you can redistribute it and/or modify > >>> it + * under the terms of the GNU General Public License as published > >>> by the + * Free Software Foundation; either version 3, or (at your > >>> option) any + * later version. > >>> + * > >>> + * This file is distributed in the hope that it will be useful, but > >>> + * WITHOUT ANY WARRANTY; without even the implied warranty of > >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >>> + * General Public License for more details. > >>> + * > >>> + * Under Section 7 of GPL version 3, you are granted additional > >>> + * permissions described in the GCC Runtime Library Exception, versi= on > >>> + * 3.1, as published by the Free Software Foundation. > >>> + * > >>> + * You should have received a copy of the GNU General Public License > >>> and + * a copy of the GCC Runtime Library Exception along with this > >>> program; + * see the files COPYING3 and COPYING.RUNTIME respectively.= =20 > >>> If not, see + * . > >>> + */ > >>=20 > >> This header only contains gdb bits. I don't see a reason for making > >> it GPL w/ runtime exception, rather than regular GPLv3+. > >> Was it just a copy/paste? > >=20 > > from the top of the file: > > /* > > * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not > > * include this directly, but pull in i386-cpuid.h and use that func. > > */ >=20 > That's the header of i386-gcc-cpuid.h. But I'm talking about (and have > quoted) i386-cpuid.h, the wrapper. too many cpuids :p technically, i386-cpuid.h was spawned from the gdb/testsuite/gdb.arch/i386- cpuid.h which itself was spawned from the gcc sources (and both include the= =20 exception) which is why the header was retained. then again, FSF owns both, so if we want to drop that, it shouldn't be an=20 issue. doesn't matter to me either way. -mike --nextPart2779247.Wm6TSe28zZ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRwcxUAAoJEEFjO5/oN/WBYOIP/AjbBBbPXlZhOc2A5Z6xHTKf CE0MJ0sMN3mbW0DS0ZOpj5sIKUkiDxP6F5xZjI6COh9Tpi+hVfTpK9MMMi2QxZlD C3mqLUNVNs3cW4EF9lRv+zNfhwHuauWSo3Xho1Y7FonvE9NUP8FSL4wkehDD+dVr J69M1bUPgGXlFCMNtKUo2BB+npcLWhWnXqpm9nBds3aOwqw5Cs/TLkk34q+WQKhU fqiaPOnnEdlFy9IASA2rmALOZUX4z73+YNlZlws4iQyfhy/mRJRc9DdulspIGsPA ZzALjPjokkwuULyVY0nuD8vqpbWgjRnsAR36zecupdr9zNfG/11LZaEFuT1Nm0PG smQ4HAEYJhrqs/REANKZc3fZdYci8Dh5lZCfM/GTYNniu/V27rCZ3N94AVVx2mTy X6Z1tuvS8PaI44haoP2nB+kJbjPpxWEBJBK4r1COiv0NWsb93d9PvDM3epxTEkhb w9ayMZa2xertVmnUF+04nwXOh6MAqxsRuBzcllml5frY2Pnavj8eZ0m0Z1wVycd/ VqYWgFInd5gjrjSCi3R9JZIeLrUuh5d4qSVUmjZbekkbaISh/J3w2nmPsq+IWJAs zyHFbU82rr4E33Uv640m9f6nf0p9uIPWXOEW3DzZr6KBmse6OA1NwHC9xsqXVvxE kV4cfMFr5tAGb/XJcEph =u9MP -----END PGP SIGNATURE----- --nextPart2779247.Wm6TSe28zZ--