From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29134 invoked by alias); 19 Jun 2013 14:53:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29123 invoked by uid 89); 19 Jun 2013 14:53:52 -0000 X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 14:53:51 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id E863733E45F; Wed, 19 Jun 2013 14:53:49 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v3] gdb: clean up x86 cpuid implementations Date: Wed, 19 Jun 2013 15:06:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201305061451.24861.vapier@gentoo.org> <201306182246.54166.vapier@gentoo.org> <51C1996E.1010001@redhat.com> In-Reply-To: <51C1996E.1010001@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart8931761.cjcGvUfYu0"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201306191053.51709.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00493.txt.bz2 --nextPart8931761.cjcGvUfYu0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1666 On Wednesday 19 June 2013 07:43:42 Pedro Alves wrote: > On 06/19/2013 03:46 AM, Mike Frysinger wrote: > However, BTW, I failed to notice this before, but: > > +++ b/gdb/common/i386-cpuid.h > > @@ -0,0 +1,68 @@ > > +/* > > + * Copyright (C) 2007-2013 Free Software Foundation, Inc. > > + * > > + * This file is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by t= he > > + * Free Software Foundation; either version 3, or (at your option) any > > + * later version. > > + * > > + * This file is distributed in the hope that it will be useful, but > > + * WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > > + * General Public License for more details. > > + * > > + * Under Section 7 of GPL version 3, you are granted additional > > + * permissions described in the GCC Runtime Library Exception, version > > + * 3.1, as published by the Free Software Foundation. > > + * > > + * You should have received a copy of the GNU General Public License a= nd > > + * a copy of the GCC Runtime Library Exception along with this program; > > + * see the files COPYING3 and COPYING.RUNTIME respectively. If not, s= ee > > + * . > > + */ >=20 > This header only contains gdb bits. I don't see a reason for making > it GPL w/ runtime exception, rather than regular GPLv3+. > Was it just a copy/paste? from the top of the file: /* * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not * include this directly, but pull in i386-cpuid.h and use that func. */ -mike --nextPart8931761.cjcGvUfYu0 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRwcX/AAoJEEFjO5/oN/WBIF0P/jR76boY2nVy495wk4ntWjgC YRw3g+RjIgQc+Y/A6j8qd0muLCnpr4+SSGDdTVW/9MVEU9/fBVDsuO/xXltO2AoU i1HX0Tnw+TsAM9JoztuYo24Ka29laZDABJgPxvcev3oEl5pMKc2QHPf3pSmwRPeY aKuqX8LUGug8WzAeUe0FAYQbYxv8qDtCV0k53uxatUx0ZLNLfatuJ1qC+/1vMgka 8NAWDHKV0SRBRspbXThPJ1P7jtQkDAIoMdj7BID0wssoUr05/5kH11QajuSDqntx z8C+uZVqJjH/6GIw7t7uuK43s1RxBj+MwBuOiuH3SBnVoURQjlaDfydbrmNuhy7V FrlPB1FGN/1tN9CTva9sYZaNH2PRhdMk/IaYCLk972xNb4VBVYBngryFUfxKk1tk jMpANJysg4nl9MxrJjVGrvbkof5MBE2fyXf7QIJ+JLJq66XwNRarcbaZ6B9rejHh 2PhW0TqKmTFkCAtmMKxhfnnifDl1GkDOtkvq0nULCuIPvWBFMbwRg8Uvakloe03U 7ixpKVF+D0hFpJJQFeeR7WIItpcoXSojchCKpmxgqNl5Z9kka2Oo9SLUlJuIjXnl D3Pvw3B6Gh4vZpbhFnoIF/kxV/hsdU6q19zMhIo9f2LckZOsmuKzbbpYFBGJkknB 5h+0sW4wReUw8Kuhn1cd =IXwG -----END PGP SIGNATURE----- --nextPart8931761.cjcGvUfYu0--