From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30424 invoked by alias); 19 Jun 2013 02:46:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30397 invoked by uid 89); 19 Jun 2013 02:46:52 -0000 X-Spam-SWARE-Status: No, score=-9.6 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 02:46:50 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 98DF733DA22; Wed, 19 Jun 2013 02:46:48 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v3] gdb: clean up x86 cpuid implementations Date: Wed, 19 Jun 2013 03:12:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201305061451.24861.vapier@gentoo.org> <201306181352.59833.vapier@gentoo.org> <51C0A4A3.1000701@redhat.com> In-Reply-To: <51C0A4A3.1000701@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart16751871.p7dxPaYvx7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201306182246.54166.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00470.txt.bz2 --nextPart16751871.p7dxPaYvx7 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1982 On Tuesday 18 June 2013 14:19:15 Pedro Alves wrote: > On 06/18/2013 06:52 PM, Mike Frysinger wrote: > > On Monday 17 June 2013 13:40:52 Pedro Alves wrote: > >> On 06/17/2013 07:05 AM, Mike Frysinger wrote: > >>> ping ... > >>=20 > >> ... pong. > >>=20 > >> ENOCHANGELOG > >=20 > > i usually wait for the code to get reviewed before i waste time > > autogenerating the ChangeLog entries. if people are happy with the code > > now, i can move on to the last part before merging. >=20 > Well, that's not the project's policy. ChangeLogs are supposed to > be reviewed too. >=20 > But let's stop this before it gets into a ChangeLog-are-useless > argument... I know you write good ChangeLog entries. ;-) i'm not trying to argue against ChangeLogs (i know it's a lost cause w/gdb)= .=20=20 just pointing out that i prefer to wait to the last minute to write it sinc= e=20 it has no real bearing on the actual code review. here's the ChangeLog entries for this patch. gdb/: 2013-06-18 Mike Frysinger * Makefile.in (HFILES_NO_SRCDIR): Add common/i386-cpuid.h and common/i386-gcc-cpuid.h. * common/i386-cpuid.h: New wrapper header around i386-gcc-cpuid.h. * common/i386-gcc-cpuid.h: Rename from testsuite/gdb.arch/i386-cpuid.h. Copy the latest version from upstream gcc. * common/linux-btrace.c: Include i386-cpuid.h. (intel_supports_btrace): Delete x86 ifdefs and replace inline asm with call to i386_cpuid. (cpu_supports_btrace): Likewise. * go32-nat.c: Include i386-cpuid.h. (go32_sysinfo): Add (disabled) calls to i386_cpuid with comments. gdb/testsuite/: 2013-06-18 Mike Frysinger * gdb.arch/i386-avx.c (have_avx): Change __get_cpuid call to i386_cpuid. * gdb.arch/i386-avx.exp (additional_flags): Add -I${srcdir}/../common. * gdb.arch/i386-cpuid.h: Moved to ../common/i386-gcc-cpuid.h. * gdb.arch/i386-sse.c: Call new i386_cpuid function. * gdb.arch/i386-see.exp (additional_flags): Add -I${srcdir}/../common. -mike --nextPart16751871.p7dxPaYvx7 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRwRueAAoJEEFjO5/oN/WBjBQP/0xy4gzY8WPVe2DUcmONC7TA ixSiNucp9kdGiI9XqXfkBno00zmzUCbCLqattFUrt5tfiVdiN1Er2+Se24LS7s0m mLhw4zW9QmbQ9GFd+R9xCDnYlYtEWiZV3aclh7e/ve+27ABqOTt+tDvkEwdxNxff HR1eYYBWkVJFtUFQOeXjh759xo+cbscEJ19PzTb3HrHiKoeKO0Df3DkoQjFMbfp3 0j4dP7/RUu6Kfddn0w1le8+KgaG+5k5IH40zCukooSNQIYLbQd3/4cLfC5oipd/a PWtE2Qr9hjYLwgS5jRrDnxju3C4shisidPYT9aNvtYRv04TRmuiph1rYG3heTk8C Wgy5U7IoJqgj4mtN2E7oL6xAvtphJzL7eXA8WB4bS9y6hz1qWsG24eWSBwupjKt+ kZ3/j2sEuk1UJOUvMe4M/nctlHJcBf3t93GIxK8hJ5+sOgHWjRG1IJdccRi3ffOg /EaL8z6STe87BscebdztUNuaHkBQoaRb7PrhcL97514/+ZPKCAg2J+hZAF9W2AnL PNNl/voLFvaFJIrdsr08fiiHz4PEUOEG9CjGRaqPXYYAGb9GKgKvjWeQMc7TKbx3 SRNLNkAwLVVHHybTq2LmrB+r/Mi5ihFu5m+16mF5IWWnZ+Q5o7QYg4YEMtiYu634 filwO2OSllm7Ey8rYjnv =gE6l -----END PGP SIGNATURE----- --nextPart16751871.p7dxPaYvx7--