Re: [PATCH v4] gdb: clean up x86 cpuid implementations

Pedro Alves
2013-06-19T17:37:55Z

On 06/19/2013 06:24 PM, Mike Frysinger wrote:

> gdb/:
> 2013-06-18 Mike Frysinger <vapier@gentoo.org>
>
> * Makefile.in (HFILES_NO_SRCDIR): Add common/i386-cpuid.h and
> common/i386-gcc-cpuid.h.
> * common/i386-cpuid.h: New wrapper header around i386-gcc-cpuid.h.
> * common/i386-gcc-cpuid.h: Rename from testsuite/gdb.arch/i386-cpuid.h.
> Copy the latest version from upstream gcc.
> * common/linux-btrace.c: Include i386-cpuid.h.
> (intel_supports_btrace): Delete x86 ifdefs and replace inline asm with
> call to i386_cpuid.
> (cpu_supports_btrace): Likewise.
> * go32-nat.c: Include i386-cpuid.h.
> (go32_sysinfo): Add (disabled) calls to i386_cpuid with comments.
>
> gdb/testsuite/:
> 2013-06-18 Mike Frysinger <vapier@gentoo.org>
>
> * gdb.arch/i386-avx.c (have_avx): Change __get_cpuid call to i386_cpuid.
> * gdb.arch/i386-avx.exp (additional_flags): Add -I${srcdir}/../common.
> * gdb.arch/i386-cpuid.h: Moved to ../common/i386-gcc-cpuid.h.
> * gdb.arch/i386-sse.c: Call new i386_cpuid function.
> * gdb.arch/i386-see.exp (additional_flags): Add -I${srcdir}/../common.

OK.

Thanks!

--
Pedro Alves