Re: [PATCH v3] gdb: clean up x86 cpuid implementations

Mike Frysinger
2013-06-19T02:46:58Z

[-- Attachment #1: Type: Text/Plain, Size: 2011 bytes --]

On Tuesday 18 June 2013 14:19:15 Pedro Alves wrote:
> On 06/18/2013 06:52 PM, Mike Frysinger wrote:
> > On Monday 17 June 2013 13:40:52 Pedro Alves wrote:
> >> On 06/17/2013 07:05 AM, Mike Frysinger wrote:
> >>> ping ...
> >>
> >> ... pong.
> >>
> >> ENOCHANGELOG
> >
> > i usually wait for the code to get reviewed before i waste time
> > autogenerating the ChangeLog entries. if people are happy with the code
> > now, i can move on to the last part before merging.
>
> Well, that's not the project's policy. ChangeLogs are supposed to
> be reviewed too.
>
> But let's stop this before it gets into a ChangeLog-are-useless
> argument... I know you write good ChangeLog entries. ;-)

i'm not trying to argue against ChangeLogs (i know it's a lost cause w/gdb).
just pointing out that i prefer to wait to the last minute to write it since
it has no real bearing on the actual code review.

here's the ChangeLog entries for this patch.
gdb/:
2013-06-18 Mike Frysinger <vapier@gentoo.org>

* Makefile.in (HFILES_NO_SRCDIR): Add common/i386-cpuid.h and
common/i386-gcc-cpuid.h.
* common/i386-cpuid.h: New wrapper header around i386-gcc-cpuid.h.
* common/i386-gcc-cpuid.h: Rename from testsuite/gdb.arch/i386-cpuid.h.
Copy the latest version from upstream gcc.
* common/linux-btrace.c: Include i386-cpuid.h.
(intel_supports_btrace): Delete x86 ifdefs and replace inline asm with
call to i386_cpuid.
(cpu_supports_btrace): Likewise.
* go32-nat.c: Include i386-cpuid.h.
(go32_sysinfo): Add (disabled) calls to i386_cpuid with comments.

gdb/testsuite/:
2013-06-18 Mike Frysinger <vapier@gentoo.org>

* gdb.arch/i386-avx.c (have_avx): Change __get_cpuid call to i386_cpuid.
* gdb.arch/i386-avx.exp (additional_flags): Add -I${srcdir}/../common.
* gdb.arch/i386-cpuid.h: Moved to ../common/i386-gcc-cpuid.h.
* gdb.arch/i386-sse.c: Call new i386_cpuid function.
* gdb.arch/i386-see.exp (additional_flags): Add -I${srcdir}/../common.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]