Re: [rfc] Add help text to start-up text

Gary Benson
2013-06-13T08:20:12Z

Phil Muldoon wrote:
> This patch proposes to add a few items to the GDB start-up text to
> provide some indication on where the user can find help.

Great!

> I did not add the wiki and manual URLs to configure et al as I am
> not sure that is needed (I guess GDB packagers might have an opinion
> here).

I think they're good how they are. I can see the utility of changing
the bug-reporting URL, but not the others. It might be useful to lift
them out of the translated string, but that's just idle speculation on
my part :)

> Also I am not sure if anything actually parses the initial output of
> the GDB start-up text and if adding these lines will affect that. So
> I am seeking comments.

I really hope things aren't parsing this!

> diff --git a/gdb/top.c b/gdb/top.c
> index 8ac756f..4c85b51 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -1156,8 +1156,16 @@ Type \"show configuration\" for configuration details.");
> {
> fprintf_filtered (stream,
> _("\nFor bug reporting instructions, please see:\n"));
> - fprintf_filtered (stream, "%s.", REPORT_BUGS_TO);
> + fprintf_filtered (stream, "%s.\n\n", REPORT_BUGS_TO);
> }
> +
> + fprintf_filtered (stream, _("The GDB manual can be found online at:\n\
> +<http://www.gnu.org/software/gdb/documentation/>\n"));
> + fprintf_filtered (stream, _("The GDB wiki can be found online at:\n\
> +<http://sourceware.org/gdb/wiki/>\n\n"));
> + fprintf_filtered (stream, _("For help, type 'help'.\n"));
> + fprintf_filtered (stream, _("Type 'apropos word' to search for \
> +commands related to 'word'.\n"));
> }
>
> /* Print the details of GDB build-time configuration. */

The quotes here should be \", to match those above.

Cheers,
Gary

--