From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5248 invoked by alias); 13 Jun 2013 08:20:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5232 invoked by uid 89); 13 Jun 2013 08:20:11 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.1 Received: from gbenson.demon.co.uk (HELO blade.nx) (80.177.220.214) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 13 Jun 2013 08:20:06 +0000 Received: by blade.nx (Postfix, from userid 500) id C4A3D263D5C; Thu, 13 Jun 2013 09:20:03 +0100 (BST) Date: Thu, 13 Jun 2013 09:12:00 -0000 From: Gary Benson To: Phil Muldoon Cc: "gdb-patches@sourceware.org" Subject: Re: [rfc] Add help text to start-up text Message-ID: <20130613082003.GA4510@blade.nx> Mail-Followup-To: Phil Muldoon , "gdb-patches@sourceware.org" References: <51B8D10E.5030409@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51B8D10E.5030409@redhat.com> X-SW-Source: 2013-06/txt/msg00305.txt.bz2 Phil Muldoon wrote: > This patch proposes to add a few items to the GDB start-up text to > provide some indication on where the user can find help. Great! > I did not add the wiki and manual URLs to configure et al as I am > not sure that is needed (I guess GDB packagers might have an opinion > here). I think they're good how they are. I can see the utility of changing the bug-reporting URL, but not the others. It might be useful to lift them out of the translated string, but that's just idle speculation on my part :) > Also I am not sure if anything actually parses the initial output of > the GDB start-up text and if adding these lines will affect that. So > I am seeking comments. I really hope things aren't parsing this! > diff --git a/gdb/top.c b/gdb/top.c > index 8ac756f..4c85b51 100644 > --- a/gdb/top.c > +++ b/gdb/top.c > @@ -1156,8 +1156,16 @@ Type \"show configuration\" for configuration details."); > { > fprintf_filtered (stream, > _("\nFor bug reporting instructions, please see:\n")); > - fprintf_filtered (stream, "%s.", REPORT_BUGS_TO); > + fprintf_filtered (stream, "%s.\n\n", REPORT_BUGS_TO); > } > + > + fprintf_filtered (stream, _("The GDB manual can be found online at:\n\ > +\n")); > + fprintf_filtered (stream, _("The GDB wiki can be found online at:\n\ > +\n\n")); > + fprintf_filtered (stream, _("For help, type 'help'.\n")); > + fprintf_filtered (stream, _("Type 'apropos word' to search for \ > +commands related to 'word'.\n")); > } > > /* Print the details of GDB build-time configuration. */ The quotes here should be \", to match those above. Cheers, Gary -- http://gbenson.net/