From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15368 invoked by alias); 4 Jun 2013 08:58:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15356 invoked by uid 89); 4 Jun 2013 08:58:28 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 08:58:28 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r548wQQo011784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 4 Jun 2013 04:58:26 -0400 Received: from host2.jankratochvil.net (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r548wMrj021167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 4 Jun 2013 04:58:24 -0400 Date: Tue, 04 Jun 2013 08:58:00 -0000 From: Jan Kratochvil To: Ben Cheng Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Ignore the first entry returned by svr4_current_sos_via_xfer_libraries for dynamically linked programs Message-ID: <20130604085821.GA6431@host2.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-06/txt/msg00035.txt.bz2 Hello Ben, the patch looks fine but I do not see GDB copyright assignment either yours or a Google global one. Hopefully this patch is small enough to need one. I will check it in reformatted after possibly copyright assignment reply. On Tue, 28 May 2013 20:31:31 +0200, Ben Cheng wrote: > < return library_list.head ? library_list.head : svr4_default_sos (); > --- > > /* Use the same logic that determines the 'ignore_first' variable > > below. PR - 15507 */ There should be two spaces between . and */ so that PR could be for example in parentheses. > > if (exec_bfd && bfd_get_section_by_name (exec_bfd, ".dynamic") == NULL) > > return library_list.head ? library_list.head : svr4_default_sos (); > > else > > return library_list.head && library_list.head->next ? > > library_list.head->next : svr4_default_sos (); http://www.gnu.org/prep/standards/standards.html formatting says: return (library_list.head && library_list.head->next ? library_list.head->next : svr4_default_sos ()); Thanks, Jan