From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <palves@redhat.com>, Keith Seitz <keiths@redhat.com>,
psmith@gnu.org, gdb-patches@sourceware.org
Subject: Re: [patch] Improve symbol lookup performance noted in PR 15519
Date: Mon, 03 Jun 2013 06:01:00 -0000 [thread overview]
Message-ID: <20130603060128.GB12363@adacore.com> (raw)
In-Reply-To: <20905.9501.800725.439795@ruffy.mtv.corp.google.com>
> So the speedup comes from calling a more specific lookup routine for
> the task at hand.
>
> Also note that even in the "after" case we are still doing a lot of
> duplicate lookups. cp-namespace.c is a bit clumsy in some of the
> lookups it does. Although it's hampered by having to work with the
> data structures gdb provides it. My plan is to work on both this
> summer.
This is a bit of a digression, but this reminds me that we have similar
types of issues with Ada (multiple identical lookups), and it's not
easy to prevent them. The way we've dealt with the issue is to implement
a cache, and it yielded good results. I have been meaning to contribute
that code, but it needs to be cleaned up, because the cache invalidation
is performed manually by sprinkling calls to ada-lang here and there,
wherever necessary. This should be done using observers instead, adding
new ones if necessary. Perhaps the same could benefit C++ as well,
and one could even imagine a common cache or at least caching
infrastructure.
--
Joel
next prev parent reply other threads:[~2013-06-03 6:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 23:27 Doug Evans
2013-05-31 3:42 ` Joel Brobecker
2013-05-31 9:40 ` Pedro Alves
2013-05-31 22:33 ` Doug Evans
2013-06-03 6:01 ` Joel Brobecker [this message]
2013-06-03 17:27 ` Pedro Alves
2013-06-05 22:31 ` Doug Evans
2013-06-06 10:18 ` Pedro Alves
2013-06-06 19:03 ` Doug Evans
2013-06-07 14:50 ` Fix formating in copyright headers. (was: Re: [patch] Improve symbol lookup performance noted in PR 15519) Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603060128.GB12363@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=palves@redhat.com \
--cc=psmith@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox