From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32110 invoked by alias); 31 May 2013 03:42:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32098 invoked by uid 89); 31 May 2013 03:42:40 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 31 May 2013 03:42:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5AA1D2E9DE; Thu, 30 May 2013 23:42:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rZ+kWqgqGfga; Thu, 30 May 2013 23:42:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C8AEF2E3CD; Thu, 30 May 2013 23:42:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E79EFC2379; Fri, 31 May 2013 07:42:31 +0400 (RET) Date: Fri, 31 May 2013 03:42:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Keith Seitz , psmith@gnu.org, gdb-patches@sourceware.org Subject: Re: [patch] Improve symbol lookup performance noted in PR 15519 Message-ID: <20130531034231.GA4292@adacore.com> References: <20903.57436.871210.593441@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20903.57436.871210.593441@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-05/txt/msg01100.txt.bz2 > I'll let it sit for a few days in case there are any more comments. > I'd also like to commit this to the 7.6 branch. Ok Joel? > [I need to rerun the testsuite in that tree before committing there.] No problem regarding putting this fix in the 7.6 branch. Just a quick reminder, JIC, to add a entry in the 7.6 release wiki page (thank you!). > > 2013-05-30 Doug Evans > Keith Seitz > > PR 15519 > * cp-namespace.c (find_symbol_in_baseclass): Call > cp_lookup_symbol_in_namespace instead of cp_lookup_symbol_namespace. > Remove call to lookup_symbol_static. Call lookup_static_symbol_aux > unconditionally. Call check_typedef on base types before accessing > them. > (cp_lookup_nested_symbol): Fix comment. > > testsuite/ > * gdb.cp/derivation2.cc: New file. > * gdb.cp/derivation.cc (main): Call foo2. > * gdb.cp/derivation.exp: Add tests for typedefs in another > file, and when there's an active block. -- Joel