From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19614 invoked by alias); 30 May 2013 09:12:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19585 invoked by uid 89); 30 May 2013 09:12:17 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_BJ autolearn=ham version=3.3.1 Received: from gbenson.demon.co.uk (HELO blade.nx) (80.177.220.214) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 09:12:14 +0000 Received: by blade.nx (Postfix, from userid 500) id BB92A263F7C; Thu, 30 May 2013 10:12:11 +0100 (BST) Date: Thu, 30 May 2013 09:12:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [RFA 2/7 take 2] API for inhibiting section map updates Message-ID: <20130530091211.GA5357@blade.nx> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org, Tom Tromey References: <20130516144340.GA2105@blade.nx> <20130516144813.GC2105@blade.nx> <87mwrpohnv.fsf@fleche.redhat.com> <20130524074737.GB4602@blade.nx> <51A63846.70905@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51A63846.70905@redhat.com> X-SW-Source: 2013-05/txt/msg01047.txt.bz2 Pedro Alves wrote: > On 05/24/2013 08:47 AM, Gary Benson wrote: > > /* Update the table in exec_ops, used to read memory. */ > > ALL_OBJFILE_OSECTIONS (objfile, s) > > @@ -1291,11 +1300,14 @@ static void > > update_section_map (struct program_space *pspace, > > struct obj_section ***pmap, int *pmap_size) > > { > > + struct objfile_pspace_info *pspace_info; > > int alloc_size, map_size, i; > > struct obj_section *s, **map; > > struct objfile *objfile; > > > > - gdb_assert (get_objfile_pspace_data (pspace)->objfiles_changed_p != 0); > > + pspace_info = get_objfile_pspace_data (current_program_space); > > Shouldn't this be 'pspace' instead of 'current_program_space'? Good catch, thank you. Gary -- http://gbenson.net/