From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12907 invoked by alias); 23 May 2013 05:16:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12888 invoked by uid 89); 23 May 2013 05:16:24 -0000 X-Spam-SWARE-Status: No, score=-9.6 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 05:16:23 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 40C1A33E144; Thu, 23 May 2013 05:16:22 +0000 (UTC) From: Mike Frysinger To: nick clifton Subject: Re: [RFC] msp430 instruction decoder Date: Thu, 23 May 2013 05:16:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.8.3; KDE/4.6.5; x86_64; ; ) Cc: binutils@sourceware.org, Kevin Buettner , gdb-patches@sourceware.org References: <20130516150246.2463f977@mesquite.lan> <201305171354.20292.vapier@gentoo.org> <519C9A46.4010302@redhat.com> In-Reply-To: <519C9A46.4010302@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart31852064.hnguG9KtDK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201305230116.28453.vapier@gentoo.org> X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00866.txt.bz2 --nextPart31852064.hnguG9KtDK Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1612 On Wednesday 22 May 2013 06:13:26 nick clifton wrote: > >> +typedef struct > >> +{ > >> + MSP430_Opcode_Decoded * msp430; > >=20 > > shouldn't the style be: > > MSP430_Opcode_Decoded *msp430; > >=20 > > seems like general style guidelines are violated a lot in this file. do > > we normally ignore that in the opcodes/ tree ? >=20 > No, and I have revised the formatting in the patch files. They do now > conform to the GNU Coding Standard. Note - the msp430-decode.opc file > includes some comments that do not quite conform to the standard. This > is because these comments are directives to the opc2c program and need > to remain in their current format. >=20 > Do you have any more concerns with this patch ? style around MSP430_Opcode_Operand struct decl in the header needs a little= =20 tweaking the .opc could do with a little tweaking: - space before () in the B define when calling GETBYTE - should OP and OPX have spaces after each comma in the arg list ? seems = to=20 happen with a bunch of other macros too ... - OP and OPX should also not have a space before the final ) - indentation after UNSUPPORTED and IMMU and IMMS should prob be tabs and = not=20 spaces - F_____ (and the two after it) have a tab after the #define rather than a= =20 space - in msp430_decode_opcode, are the multiple macro calls on the same line o= n=20 purpose, or should those get fixed to be one per line ? for example: ID (dopc_to_id (dopc)); ASX (sreg, as, srxt_bits); ADX (dreg, a, dsxt_bit= s);=20 ABW (al_bit, b); the heavy macro usage is understandable in these sorts of things and common -mike --nextPart31852064.hnguG9KtDK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJRnaYsAAoJEEFjO5/oN/WBz5cQAKVex5cVm0U11Clk/OIxPDnU gxmi9PiYjCBfpdCD8nDzHdxYxbTUZ1NahFKGE4qNauR82FiR1lLeggII+/J3VRlR J2fsaCKv0d6aer+/2MaHtN+eCF5F3Q/NVEd38B6kuir72EeARghF6cGFMGlG/4lT ++k3WZeTWJNxgxj/aTFHd8sONkL881nlQ+g/Q/vDq30KdDlm+ItZWOKX59BhPlZY EUrIxBliw3/1iAAalDHJb3IM3dB/wIDLiLR98omqJ1Ed6h29uYdwLR9Ehgtrn3cw bfxVlQZlP58u2hJAvrcbbZP9F58h6+sBNM2R6iUNx8En5WVc9zc1LCOIlr1ihroU 6EDsd9G4o262DZj945mqOWEzHJJYtHoBCFm0EqD7iYGnOAajoA2KhyY/9lWM/GO7 ds6VRU5cv5KbYm+b5aiv72WL9O6hZBav1Pk9S+4GgFUtoZuykz6WT84HEm6CSVm8 8AlHxHZtv/AXopRAK4ZG8i2V7xxUnd00VAGD7jGHssvoPZzvqpzeaINf0rJ4Urs0 WAzT47s9+gdJVipGaescoKy7GCnbyITjMfCh/srUeTlE+xZSPnxiSHdLWNwZjitY cZhHTUER+vOgAoo6YSDM6exStm6ZkBgFhJc7cUUhOdkh2hye/v5oqIBILIdeqky+ lL4cv8IYU3DcUVLyz/UQ =84Uj -----END PGP SIGNATURE----- --nextPart31852064.hnguG9KtDK--