From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31867 invoked by alias); 22 May 2013 10:32:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31839 invoked by uid 89); 22 May 2013 10:32:52 -0000 X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.1 Received: from gbenson.demon.co.uk (HELO blade.nx) (80.177.220.214) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 22 May 2013 10:32:50 +0000 Received: by blade.nx (Postfix, from userid 500) id 6207C263EBF; Wed, 22 May 2013 11:32:47 +0100 (BST) Date: Wed, 22 May 2013 10:32:00 -0000 From: Gary Benson To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix crash in svr4_clear_so Message-ID: <20130522103247.GA8759@blade.nx> Mail-Followup-To: Paul Pluzhnikov , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SW-Source: 2013-05/txt/msg00822.txt.bz2 Paul Pluzhnikov wrote: > Using current trunk, I've got a GDB core dump when I tried to analyze > mis-matched binary and core: ... > Index: solib-svr4.c > =================================================================== > RCS file: /cvs/src/src/gdb/solib-svr4.c,v > retrieving revision 1.177 > diff -p -u -r1.177 solib-svr4.c > --- solib-svr4.c 6 May 2013 22:18:38 -0000 1.177 > +++ solib-svr4.c 21 May 2013 22:19:09 -0000 > @@ -971,7 +971,8 @@ svr4_free_so (struct so_list *so) > static void > svr4_clear_so (struct so_list *so) > { > - so->lm_info->l_addr_p = 0; > + if (so->lm_info != NULL) > + so->lm_info->l_addr_p = 0; > } > > /* Free so_list built so far (called via cleanup). */ Looks good to me. Thanks, Gary -- http://gbenson.net/